Skip to content

Commit

Permalink
fix confusion around mail settings
Browse files Browse the repository at this point in the history
Signed-off-by: Simon L <szaimen@e.mail.de>
  • Loading branch information
szaimen committed Jun 17, 2023
1 parent bd3f3af commit eb1afa8
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions apps/settings/templates/settings/admin/additional-mail.php
Expand Up @@ -29,8 +29,8 @@
];

$mail_smtpsecure = [
'' => $l->t('None'),
'ssl' => $l->t('SSL/TLS')
'' => $l->t('None/STARTTLS'),
'ssl' => $l->t('SSL')
];

$mail_smtpmode = [
Expand Down Expand Up @@ -72,7 +72,9 @@
<option value="<?php p($smtpmode[0])?>" <?php p($selected) ?>><?php p($smtpmode[1]) ?></option>
<?php endforeach;?>
</select>
</p>

<p>
<label id="mail_smtpsecure_label" for="mail_smtpsecure"
<?php if ($_['mail_smtpmode'] !== 'smtp') {
print_unescaped(' class="hidden"');
Expand All @@ -91,7 +93,9 @@
<option value="<?php p($secure)?>" <?php p($selected) ?>><?php p($name) ?></option>
<?php endforeach;?>
</select>
</p>

<p>
<label id="mail_sendmailmode_label" for="mail_sendmailmode" class="<?= $_['mail_smtpmode'] !== 'sendmail' ? 'hidden' : '' ?>">
<?php p($l->t('Sendmail mode')); ?>
</label>
Expand Down Expand Up @@ -123,10 +127,8 @@
<p id='setting_smtpauth' <?php if ($_['mail_smtpmode'] !== 'smtp') {
print_unescaped(' class="hidden"');
} ?>>
<label for='mail_smtpauthtype'><?php p($l->t('Authentication method')); ?>
<span class="icon-info" title="<?php p($l->t('Only applies when authentication is required')); ?>"></span>
</label>
<select name="mail_smtpauthtype" id="mail_smtpauthtype" disabled="disabled">
<label for='mail_smtpauthtype'><?php p($l->t('Authentication')); ?></label>
<select name="mail_smtpauthtype" id="mail_smtpauthtype" class="hidden">
<?php foreach ($mail_smtpauthtype as $authtype => $name): ?>
<option value="<?php p($authtype) ?>"><?php p($name) ?></option>
<?php endforeach; ?>
Expand Down

0 comments on commit eb1afa8

Please sign in to comment.