Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to open file or folder with keyboard #10008

Closed
jancborchardt opened this issue Jun 26, 2018 · 6 comments · Fixed by #10310
Closed

Unable to open file or folder with keyboard #10008

jancborchardt opened this issue Jun 26, 2018 · 6 comments · Fixed by #10310
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: accessibility high
Milestone
Nextcloud 14

Comments

@jancborchardt
Copy link
Member

Currently you can navigate the file list via keyboard, with 3 Tab-clicks per row:

  • Folder/file itself
  • Sharing that folder/file
  • 3-dot menu of that folder/file

Now the problem is that pressing enter on the folder/file itself opens the right sidebar instead of opening it. We need to change it to opening, otherwise it is not possible to enter into folders or open files.

@nextcloud/designers @nextcloud/accessibility
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of high feature: accessibility labels Jun 26, 2018
@jancborchardt jancborchardt added this to the Nextcloud 14 milestone Jun 26, 2018
@skjnldsv
Copy link
Member

@jancborchardt didn't we said we'll add this for 15?
With the new files app?

@nextcloud nextcloud deleted a comment from nextcloud-bot Jun 26, 2018
@jancborchardt
Copy link
Member Author

@skjnldsv since changing this is such a small change but a really important accessibility fix to use files at all, we should absolutely do it for 14.

I mean, I assume it’s a small change cause it’s just switching from opening sidebar to opening the file.

@jancborchardt
Copy link
Member Author

Also related is what @kevgathuku mentioned in #9994 (comment)

@tyrylu
Copy link
Contributor

tyrylu commented Jun 26, 2018

Of course, i would be grateful if it could be done for 14.

@nextcloud-bot nextcloud-bot mentioned this issue Jul 10, 2018
Closed
@jancborchardt jancborchardt mentioned this issue Jul 20, 2018
Merged
4 tasks
jancborchardt added a commit that referenced this issue Jul 20, 2018
@jancborchardt
Fix ability to open file or folder via keyboard, fix #10008
ad7181d 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

@tyrylu the fix is in #10310, if you want to review :) It will make it into Nextcloud 14! 🎉

@jancborchardt jancborchardt added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 20, 2018
@tyrylu
Copy link
Contributor

tyrylu commented Jul 20, 2018

Thank you, i'll look into it, at least i hope that i will have some time.

jancborchardt added a commit that referenced this issue Jul 20, 2018
@jancborchardt
Fix ability to open file or folder via keyboard, fix #10008
b7bf2f7 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
danxuliu pushed a commit that referenced this issue Jul 24, 2018
@jancborchardt @danxuliu
Fix ability to open file or folder via keyboard, fix #10008
a2ad1b9 
Before, the file or folder was opened when clicking on the name span,
but not when clicking on the link that contains the name; clicking on
the link highlighted the file and opened the sidebar, just like clicking
on the file size or date. Now clicking on the link opens the file or
folder, so the unit tests that tested clicks on the link were changed to
test clicking on the file size instead.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
This was referenced Aug 21, 2018
Closed
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Sep 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: accessibility high
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging a pull request may close this issue.

Accessibility fixes for header and global elements nextcloud/server
3 participants
@jancborchardt @tyrylu @skjnldsv