-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quota in Files-App takes to much space #10124
Comments
I could open a pull request for the changes if nessessary. |
While I agree the .1GB here is pretty useless. It should also need a more flexible solution as certain langauges might translate it still to to long a string. |
What could we do? I have no clue whats best here |
Me neither. @nextcloud/designers input please :D |
I'd say we can just add an ellipsis at the end if the text gets too long or we can just get rid of the verb and use "300GB of 500GB", since it should be clear that this is about the used space. |
I have an open pull request, which edits the fileapp (and even the file which handles the quota). |
@newhinton do it :) |
A new PR please. ;) |
@MorrisJobke I already added the commit to the existing pr. ^^ |
Sounds good, but only if the value is
Disagree here @juliushaertl, as that is then way too technical and not so friendly. Another option would be to make sure that the units are always the same (both GB, or both MB for example), then we only have to show the unit once. So it would be:
or
|
At the moment, the filesize is reduced in the following cases: this can easily be changed and or expanded to fit our needs |
@newhinton cool! Could you adjust it as I described then? Would be awesome! :) (Also, it seems your pull request at #10245 is a bit broken cause it has a ton of commits in there?) |
@jancborchardt yes that may indeed be true, i guess i made a mistake as i tried to update my fork. I'll update or redo the PR when i have time to do so :) |
@jancborchardt I have recreated the pr. Currently the filesizes are reduced when quota (used and total) shows:
This would be way to complicated for little gain. Consider a combination like this: The current display is set to
instead of
which was in the old pullrequest. |
Steps to reproduce
Nextcloud version:
13.0.4
The Quota can break out of the intended bounds. This breaks the style.
I propose to cut off sub-zero decimal places to gather more space if the used and or available exceeds a given size.
The text was updated successfully, but these errors were encountered: