Feature/10124/quota takes too much space #10321
Conversation
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
…thub.com/nextcloud/server into feature/10124/quota-takes-too-much-space
|
cc @nextcloud/designers |
| @@ -430,5 +430,4 @@ public function getNodeType($folderpath) { | |||
| return $node->getType(); | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Would it be possible to revert this one?
| } | ||
|
|
||
| return $reducedStorageSize . " " . $ending; | ||
| } |
There was a problem hiding this comment.
Would you mind to squash all the commits into one?
MorrisJobke
added
enhancement
design
|
@newhinton as review, but also answering to your comment at #10124 (comment)
In that case simply use "less than":
We should not show the unit twice, and using two different units is confusing for quick info gathering. |
|
@jancborchardt I have implemented the minimalistic way @MorrisJobke I would sqash, or change the history (i messed it quite up) but git for windows and the pgp-signing don't play well together. If you wish, i could make a new branch? |
That would be nice :) And also while doing it you could fix the merge conflict 🙈 Thanks a lot for your help here 👍 |
|
@jancborchardt @MorrisJobke While i was recreating the pr, i discussed this with some people, and we had the great idea to not show the used size at all. Something like 65% of 6TB would be way more informative to the user on the first glance, and when he needs more precise information, he can look at the tooltip/his settings. ( Maybe we could create a modal in the future, which opens when the quota item is clicked, as i discussed with @jancborchardt ) |
See #10124
Closes #10245