Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app to specify it doesn't work with user key server side encryption #10141

Open
rullzer opened this issue Jul 7, 2018 · 7 comments
Open

Comments

@rullzer
Copy link
Member

rullzer commented Jul 7, 2018

It would make sense if apps can specify they do not work with server side encryption with user keys.

Apps that run not as the user (previewgenerator, richdocuments for example) have now have to somehow hack around this.

  1. Preview generator just blocks when encryption is enabled
  2. Richdocuments makes sure files are encrypted with the system key (so as if they are publicly shared)

Both are not ideals and add a lot of weird code.
Apps should not have to care. I don't want to write a lot of encryption checks for apps. I just want to write code with our APIs. So if somebody uses user keys they can't use my app.

@schiessle @nickvergessen @MorrisJobke input please :)

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10120 (allow to disable encryption), #10121 (allow to disable encryption), #9368 (Encrypt appdata when using server side encryption with master key), #4531 (Allow app to specify dependency on other app), and #6350 (does not allow me to create users).

@MorrisJobke
Copy link
Member

Makes a lot of sense to indicate this to the admins. Should this be an indicator in the info.xml? What happens if the app is enabled first and then encryption is enabled? Should it be automatically disabled or the activation of encryption being blocked?

@rullzer
Copy link
Member Author

rullzer commented Jul 9, 2018

Yes I think info.xml is the right place for this.

Regarding enabling encryption I would vote:

  1. Show a list, those apps will be disabled once you enable it
  2. Disable the apps automatically then.

@MorrisJobke
Copy link
Member

Regarding enabling encryption I would vote:

Show a list, those apps will be disabled once you enable it
Disable the apps automatically then.

I would vote for:

  • you can't enable encryption until those incompatible apps are disabled

@nickvergessen
Copy link
Member

I would vote for:
you can't enable encryption until those incompatible apps are disabled

Sounds much easier and more convinient

@rullzer
Copy link
Member Author

rullzer commented Jul 10, 2018

Fine by me :)

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 17, 2019
@szaimen

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants