Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to disable encryption #10120

Merged
merged 1 commit into from
Jul 9, 2018
Merged

allow to disable encryption #10120

merged 1 commit into from
Jul 9, 2018

Conversation

schiessle
Copy link
Member

it should be possible to disable encryption and continue to read/write/update files.

Test:

  1. Enable encryption
  2. Upload a file to generate a encrypted file on the server
  3. disable encryption occ encryption:disable but keep the "Default Encryption Module" app enabled so that old files can still be read
  4. check if you can upload new (unencrypted) files, read old (encrypted) files, edit old (encrypted) files and replace the file with a unencrypted version.

@schiessle
allow to disable encryption
5d0fa12 
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle schiessle added this to the Nextcloud 14 milestone Jul 5, 2018
@schiessle schiessle added the 3. to review Waiting for reviews label Jul 5, 2018
@schiessle schiessle mentioned this pull request Jul 5, 2018
Merged
rullzer
rullzer approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘
fine by me

@nextcloud-bot nextcloud-bot mentioned this pull request Jul 7, 2018
Open
MorrisJobke
MorrisJobke approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 103c8c3 into master Jul 9, 2018
@MorrisJobke MorrisJobke deleted the allow-to-disable-encryption branch July 9, 2018 11:40
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 5, 2018
Open
8 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 17, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: encryption (server-side)
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@schiessle @rullzer @MorrisJobke