Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening details after coming from favorites view is broken #10398

Closed
MorrisJobke opened this issue Jul 25, 2018 · 5 comments · Fixed by #10509
Closed

Opening details after coming from favorites view is broken #10398

MorrisJobke opened this issue Jul 25, 2018 · 5 comments · Fixed by #10509

Comments

@MorrisJobke
Copy link
Member

Acceptance tests fail:

# /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:14
Scenario: viewing a favorite file in its folder does not prevent opening the details view in "All files" section
  Given I am logged in
  And I mark "welcome.txt" as favorite
  And I see that "welcome.txt" is marked as favorite
  And I open the "Favorites" section
  And I open the details view for "welcome.txt"
  And I see that the details view is open
  And I view "welcome.txt" in folder
  And I see that the current section is "All files"
  When I open the details view for "welcome.txt"
  Then I see that the details view is open
    The details view is not open yet after 100 seconds

For me the details view opens in Safari, but the error in the console is still there.

JS console:

TypeError: undefined is not an object (evaluating 'OCA.Files.App.fileList.changeDirectory(fileModel.get('path'), true, true).then')

bildschirmfoto 2018-07-25 um 17 41 23

cc @skjnldsv @juliushaertl @danxuliu @nextcloud/javascript

That is now the only failing test and we could maybe look into this.

@violoncelloCH
Copy link
Member

violoncelloCH commented Aug 2, 2018

For me the details view opens in Safari, but the error in the console is still there.

@MorrisJobke for me the details bar doesn't open in Firefox
and it's the same if I'm coming from the shares view as I detected in #10516 in correlation with another bug
if I do the same with recent view and tags view, the details view doesn't open as well

@skjnldsv
Copy link
Member

skjnldsv commented Aug 3, 2018

@violoncelloCH did you cleared your cache?
The details bar opens on my side.

@violoncelloCH
Copy link
Member

violoncelloCH commented Aug 3, 2018

@skjnldsv Yes, I even tested it with a fresh firefox installation and it doesen't work for me there with beta2

@juliushaertl
Copy link
Member

@skjnldsv Doesn't work here either:

  1. Open All files
  2. Open Details view
  3. Open Favorites
  4. Open Details view
  5. Open All files
  6. Open Details view 💥

See #10509 for a possible fix

@skjnldsv
Copy link
Member

skjnldsv commented Aug 3, 2018

Ah, I misread the issue, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants