Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout of admin tag management needs adjustments #10420

Closed
nickvergessen opened this issue Jul 27, 2018 · 5 comments
Closed

Layout of admin tag management needs adjustments #10420

nickvergessen opened this issue Jul 27, 2018 · 5 comments
Labels
bug design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. regression
Milestone

Comments

@nickvergessen
Copy link
Member

The "icon buttons" are too close together:

bildschirmfoto von 2018-07-27 08-56-36

Even worse with the delete button on edit:

bildschirmfoto von 2018-07-27 08-58-25

cc @nextcloud/designers

@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Jul 27, 2018
@nextcloud-bot nextcloud-bot added the papercut Annoying recurring issue with possibly simple fix. label Jul 27, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #2347 (Recent file list layout adjustment), #5399 (Group admin cannot change settings in user management), #7265 (Small adjustments needed to the login screen), #3327 (Share tags), and #8555 ([RFC] Dependency Management).

@jancborchardt
Copy link
Member

In the creation flow, the x is not really necessary. It is much too dangerous to put a destructive action next to the confirm action too.

In the editing process, we should have a Save button (Ideally also with text) and a 3-dot menu with the other options in it.

@nickvergessen
Copy link
Member Author

nickvergessen commented Jul 27, 2018

In NC13 we had normal text buttons, so they where a bit bigger and no real problem.
See #10028 for comparison.

Before:
image
After:
image

Since that is the "breaking" PR, let's summon the author @juliushaertl

@MorrisJobke MorrisJobke mentioned this issue Jul 31, 2018
51 tasks
@juliushaertl
Copy link
Member

In the creation flow, the x is not really necessary. It is much too dangerous to put a destructive action next to the confirm action too.
In the editing process, we should have a Save button (Ideally also with text) and a 3-dot menu with the other options in it.

@jancborchardt So should we just move back to the regular buttons again? We don't have any buttons with images anywhere in the settings ui as far as i can tell.

How about having the create a new tag ui persistent with just a confirm button. That way we could get rid of the reset button when editing and would just have save and delete there. Delete could go into a 3 dots menu. Of course the buttons should all have a width of 44x44px, not small as they are right now.

@nickvergessen
Copy link
Member Author

Since we are currently in FF and trying to finalize the product, I'd say let's do the simple step (text-buttons) for 14 and change to whatever is best in 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. regression
Projects
None yet
Development

No branches or pull requests

4 participants