Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent file list layout adjustment #2347

Closed
MariusBluem opened this issue Nov 26, 2016 · 11 comments
Closed

Recent file list layout adjustment #2347

MariusBluem opened this issue Nov 26, 2016 · 11 comments
Labels

Comments

@MariusBluem
Copy link
Member

I think the icons of folders and files should be displayed behind the (imaginary) red line - as we do it in all the other categories 馃槈 ...what do you think 馃 @nextcloud/designers @jancborchardt

recent

@MariusBluem MariusBluem added 1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: files labels Nov 26, 2016
@Espina2
Copy link
Contributor

Espina2 commented Nov 26, 2016

@MariusBluem
I don't get what you are trying to say.

@MariusBluem
Copy link
Member Author

The icon-positions should be after the red line in my Screenshot 馃槄馃檲 @Espina2

@skjnldsv
Copy link
Member

Could you provide an example of somewhere else where we do that?

@eppfel
Copy link
Member

eppfel commented Nov 27, 2016

In the files app, there is the fav button, before the thumbnail..
bildschirmfoto 2016-11-27 um 17 12 54
But is that reason enough?

@skjnldsv
Copy link
Member

Yeah, I don't like this empty space before. Could we reverse this pr? 馃槤
Like unify the design but without a white padding before 馃槅

@phsc84
Copy link

phsc84 commented Nov 27, 2016

Why not move the fav star to the left side of the icon and make it behave the same as the mark/unmark checkbox (filled with yellow if active, otherwise invisible; displayed empty on hover)?
This would allow to consistently remove the whitespace before the icons.

@nickvergessen
Copy link
Member

Duplicate of #2193

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Nov 28, 2016
@MorrisJobke
Copy link
Member

Reopen and close the other ticket with less activity ;)

@eppfel
Copy link
Member

eppfel commented Nov 28, 2016

@PhSc But to select items, you actually click anywhere on the thumbnail, so moving the icon directly to the thumbnail would decreases usability.

I mean I don't use the favorites feature anyway. Might just an option to disable it?

@phsc84
Copy link

phsc84 commented Nov 28, 2016

My idea was, that you had to click directly on the fav star to activate it. The rest of the icon should select the item, but not activate the fav star.
But you're right, it would decrease usability a bit, because you had to click more precisely.

@nickvergessen nickvergessen changed the title Recent File Listing Icon Design Recent file list layout adjustment Nov 29, 2016
@jancborchardt
Copy link
Member

@MorrisJobke this might have more activity, but the description is confusing. ;) Closing this in favor of the original plan #2193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants