Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin 2FA backups codes use handlebars #11034

Closed
rullzer opened this issue Sep 3, 2018 · 2 comments
Closed

Admin 2FA backups codes use handlebars #11034

rullzer opened this issue Sep 3, 2018 · 2 comments
Assignees
@ChristophWurst
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
Christoph's Tasks
Milestone
Nextcloud 15

Comments

@rullzer
Copy link
Member

rullzer commented Sep 3, 2018

For https://github.com/orgs/nextcloud/projects/18

The settings page of the 2fa backupscode provider is using handlebars and does on the fly compilation. This uses eval and prevents a stricter CSP.

Probably easiest would be to move this over to vue
@rullzer rullzer added enhancement 1. to develop Accepted and waiting to be taken care of labels Sep 3, 2018
@rullzer rullzer added this to the Nextcloud 15 milestone Sep 3, 2018
@rullzer
Copy link
Member Author

rullzer commented Sep 3, 2018

@ChristophWurst

@nextcloud-bot

This comment has been minimized.

Sign in to view
@ChristophWurst ChristophWurst added this to SELECTED in Christoph's Tasks via automation Sep 7, 2018
@ChristophWurst ChristophWurst self-assigned this Sep 11, 2018
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 11, 2018
@ChristophWurst ChristophWurst moved this from SELECTED to TO REVIEW (max 4 PRs) in Christoph's Tasks Sep 11, 2018
ChristophWurst added a commit that referenced this issue Sep 11, 2018
@ChristophWurst
Migrate backup codes settings to Vue
2280cca 
Fixes #11034.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst mentioned this issue Sep 11, 2018
Merged
1 task
@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4 PRs) to IN PROGRESS (max 3 PRs) in Christoph's Tasks Sep 19, 2018
@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 3 PRs) to TO REVIEW (max 4 PRs) in Christoph's Tasks Sep 25, 2018
@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4 PRs) to IN PROGRESS (max 3 PRs) in Christoph's Tasks Sep 25, 2018
rullzer pushed a commit that referenced this issue Sep 25, 2018
@ChristophWurst @rullzer
Migrate backup codes settings to Vue
abd31d4 
Fixes #11034.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 3 PRs) to TO REVIEW (max 4 PRs) in Christoph's Tasks Sep 26, 2018
ChristophWurst added a commit that referenced this issue Sep 27, 2018
@ChristophWurst
Migrate backup codes settings to Vue
7882be1 
Fixes #11034.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE in Christoph's Tasks Sep 27, 2018
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2018
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
No open projects
Christoph's Tasks
DONE
Milestone
Nextcloud 15
Development

No branches or pull requests
3 participants
@rullzer @ChristophWurst @nextcloud-bot