Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC14.0.1 & files 1.9.0: "App is not compliant" #11563

Closed
Sanookmakmak opened this issue Oct 2, 2018 · 2 comments
Closed

NC14.0.1 & files 1.9.0: "App is not compliant" #11563

Sanookmakmak opened this issue Oct 2, 2018 · 2 comments
Labels

Comments

@Sanookmakmak
Copy link

Sanookmakmak commented Oct 2, 2018

occ app:check-code files

Analysing /var/www/html/apps/files/appinfo/app.php
 1 errors
    line   36: OC_Helper - Static method of private class must not be called
Analysing /var/www/html/apps/files/recentlist.php
 2 errors
    line   25: OCP\User - Static method of deprecated class must not be called
    line   25: OCP\User::checkLoggedIn - Method of deprecated class must not be called
Analysing /var/www/html/apps/files/templates/appnavigation.php
 1 errors
    line   88: == - is discouraged
Analysing /var/www/html/apps/files/lib/Controller/ViewController.php
 4 errors
    line  106: OC_App - Static method of private class must not be called
    line  128: OC_Helper - Static method of private class must not be called
    line  212: OC_Helper - Static method of private class must not be called
    line  216: OC_Helper - Static method of private class must not be called
Analysing /var/www/html/apps/files/lib/Controller/SettingsController.php
 1 errors
    line   41: OC_Files - Static method of private class must not be called
Analysing /var/www/html/apps/files/lib/BackgroundJob/ScanFiles.php
 1 errors
    line   92: OC_Util - Static method of private class must not be called
Analysing /var/www/html/apps/files/lib/Helper.php
 1 errors
    line   49: OC_Helper - Static method of private class must not be called
Analysing /var/www/html/apps/files/ajax/list.php
 5 errors
    line   30: OC_JSON - Static method of deprecated class must not be called
    line   82: OC_JSON - Static method of deprecated class must not be called
    line   85: OC_JSON - Static method of deprecated class must not be called
    line   93: OC_JSON - Static method of deprecated class must not be called
    line  101: OC_JSON - Static method of deprecated class must not be called
Analysing /var/www/html/apps/files/ajax/download.php
 3 errors
    line   32: OCP\User - Static method of deprecated class must not be called
    line   32: OCP\User::checkLoggedIn - Method of deprecated class must not be called
    line   64: OC_Files - Static method of private class must not be called
App is not compliant

What does this mean?
Thank you!

@Sanookmakmak Sanookmakmak changed the title NC14.0.1 & federation 1.4.0: "App is not compliant" NC14.0.1 & files 1.9.0: "App is not compliant" Oct 2, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #11560 (NC14.0.1 & Accessibility 1.01: "App is not compliant"), #11562 (NC14.0.1 & federatedfilesharing 1.4.0: "App is not compliant"), #11561 (NC14.0.1 & dav 1.6.0: "App is not compliant"), #2294 (App Store missing on 10.0.1), and #6028 (Missing icons in Files app after 12.0.1 upgrade).

@MorrisJobke
Copy link
Member

Thanks - we will fix it once we do some major refactoring. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants