Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC14.0.1 & files_sharing 1.6.2: "App is not compliant" #11565

Closed
Sanookmakmak opened this issue Oct 2, 2018 · 2 comments
Closed

NC14.0.1 & files_sharing 1.6.2: "App is not compliant" #11565

Sanookmakmak opened this issue Oct 2, 2018 · 2 comments
Labels

Comments

@Sanookmakmak
Copy link

occ app:check-code files_sharing

Analysing /var/www/html/apps/files_sharing/list.php
 2 errors
    line   23: OCP\User - Static method of deprecated class must not be called
    line   23: OCP\User::checkLoggedIn - Method of deprecated class must not be called
Analysing /var/www/html/apps/files_sharing/templates/public.php
 1 errors
    line   51: == - is discouraged
Analysing /var/www/html/apps/files_sharing/lib/External/Manager.php
 5 errors
    line   38: OCP\Files - deprecated class must not be imported with a use statement
    line  189: Files::buildNotExistingFileName - Method of deprecated class must not be called
    line  274: OC_Util - Static method of private class must not be called
    line  276: Files::buildNotExistingFileName - Method of deprecated class must not be called
    line  304: OC_Hook - Static method of private class must not be called
Analysing /var/www/html/apps/files_sharing/lib/Cache.php
 1 errors
    line  161: OC_User - Static method of private class must not be called
Analysing /var/www/html/apps/files_sharing/lib/Controller/ShareController.php
 9 errors
    line   38: OC_Files - private class must not be imported with a use statement
    line   39: OC_Util - private class must not be imported with a use statement
    line  231: OC_Hook - Static method of private class must not be called
    line  265: OC_User - Static method of private class must not be called
    line  450: OC_User - Static method of private class must not be called
    line  514: OC_Util - Static method of private class must not be called
    line  515: OC_Util - Static method of private class must not be called
    line  545: OC_Files - Static method of private class must not be called
    line  550: OC_Files - Static method of private class must not be called
Analysing /var/www/html/apps/files_sharing/lib/Controller/RemoteController.php
 2 errors
    line  117: OC_User - Static method of private class must not be called
    line  180: OC_User - Static method of private class must not be called
Analysing /var/www/html/apps/files_sharing/lib/Updater.php
 6 errors
    line   94: OCP\User - Static method of deprecated class must not be called
    line   94: OCP\User::getUser - Method of deprecated class must not be called
    line   95: OCP\User - Static method of deprecated class must not be called
    line   95: OCP\User::getUser - Method of deprecated class must not be called
    line   98: OCP\User - Static method of deprecated class must not be called
    line   98: OCP\User::getUser - Method of deprecated class must not be called
Analysing /var/www/html/apps/files_sharing/lib/Helper.php
 1 errors
    line   35: OCP\User - deprecated class must not be imported with a use statement
Analysing /var/www/html/apps/files_sharing/public.php
 1 errors
    line   32: == - is discouraged
App is not compliant

What does this mean?
Thank you!

@MorrisJobke
Copy link
Member

Thanks - we will fix it once we do some major refactoring. 👍

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #11561 (NC14.0.1 & dav 1.6.0: "App is not compliant"), #11562 (NC14.0.1 & federatedfilesharing 1.4.0: "App is not compliant"), #11564 (NC14.0.1 & files_external 1.5.0: "App is not compliant"), #11560 (NC14.0.1 & Accessibility 1.01: "App is not compliant"), and #11563 (NC14.0.1 & files 1.9.0: "App is not compliant").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants