share dialog checkboxes misbehave

[schiessle]

I just noticed that the checkboxes of the share dialog misbehave on master.

If I create a new group share this is how it looks (same happens for user shares):

"Can edit" and "Can reshare" is checked. Now I uncheck "Can reshare" and this is what happens:

"Can edit" is also unchecked! It is not just a front-end issue. If I reload the page, "Can edit" is still unckeched. So it seems we really remove all permission when the user just removes "can reshare"

If I remove "Can edit" instead the dialog behaves correctly and the "can reshare" permissions stays.

This only happens for file shares, for folders the behaviour seems to be correct. My assumption is that this is the case because for folders we have additional "edit permissions" in the '...' menu while for file shares we just have the reshare permission.

Maybe some of our @nextcloud/javascript experts can have a look.

cc @MariusBluem because we discovered and discussed it last week

[nextcloud-bot]

GitMate.io thinks possibly related issues are #2679 (Share permissions misbehaving), #3918 (share dialog broken), #2658 (Sharing and permissions), #2368 (share dialog avatar flickers on permission change), and #1094 (Sharing dialog: Names sorting is case sensitive ).

[MariusBluem]

Reproduced with Firefox and Safari on macOS yesterday - you were faster @schiessle 😅

[MorrisJobke]

@skjnldsv @danxuliu @ChristophWurst Any idea?

[MorrisJobke]

cc @nextcloud/javascript

[skjnldsv]

No idea. How is the backend? Are we sure this is only a javascript issue?

[skjnldsv]

Fixed with #15719