share dialog avatar flickers on permission change

[schiessle]

If you share a file or folder and change permissions the avatar of all shares in the list get reloaded, causing flickering

@blizzz as discussed here #2336

[nickvergessen]

Well the models are all re-rendered. The same issue happen with the rooms in spreed and IIRC this is not fixable

[schiessle]

didn't we fixed this for the spreed.me app during the hack-week?

[nickvergessen]

No, we stop reloading for no reason, but on change there is still the reload.

[MorrisJobke]

Maybe @ChristophWurst has an idea for this issue ;)

[ChristophWurst]

I assume we simply trigger a full view re-render whenever the share model changes and therefore the avatars are loaded twice. So we have to possible solutions: 1. selectively re-render only the parts of the view that really changed. 2. somehow cache the avatars to prevent that flickering.

[rullzer]

yes we rerender. We also do cache the avatars. That is why the flickering is so fast ;) Has always been there but before we did not cache so loading took more time.

[blizzz]

We can attempt to only re-render the permissions, i.e. the popup. I am having a look.

[blizzz]

See #2398 for a proof of concept

[blizzz]

What do you think, is this something for 12 or still 11? Basically done in #2398.

[MorrisJobke]

12

[schiessle]

fix was merged