Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share link main download link misleading #12378

Closed
putt1ck opened this issue Nov 9, 2018 · 1 comment · Fixed by #12398
Closed

Share link main download link misleading #12378

putt1ck opened this issue Nov 9, 2018 · 1 comment · Fixed by #12398
Labels
feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
Nextcloud 15

Comments

@putt1ck
Copy link

putt1ck commented Nov 9, 2018

When following a "share link" the top bar has a download button; if the link shared contains subfolders and the end (first time!) user navigates to the a subfolder containing a file of interest, the button marked "download" implies it downloads the item, rather than all the contents downstream of the original link. Changing "download" to "download everything" would significantly reduce the potential for confusion.
@putt1ck putt1ck added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: sharing labels Nov 9, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #3613 (Shared folder download issues), #5547 (When sharing "Upload Only" link, have theme background), #6841 (One-time download links), #8343 (Share by link (read-only): upload button), and #12136 (mp3 with brackets in name doesn't open in web or preview/download from shared link).

violoncelloCH added a commit that referenced this issue Nov 10, 2018
@violoncelloCH
change "Download" to "Download all files" for shared folders
1f237c7 
fixes #12378

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@violoncelloCH violoncelloCH mentioned this issue Nov 10, 2018
Merged
@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging a pull request may close this issue.

change "Download" to "Download all files" for shared folders nextcloud/server
3 participants
@MorrisJobke @putt1ck @nextcloud-bot