Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical changes for developers & admins for Nextcloud 16 #12915

Closed
rullzer opened this issue Dec 7, 2018 · 5 comments
Closed

Critical changes for developers & admins for Nextcloud 16 #12915

rullzer opened this issue Dec 7, 2018 · 5 comments
Labels
overview
Milestone
Nextcloud 16

Comments

@rullzer
Copy link
Member

rullzer commented Dec 7, 2018 •
edited by blizzz
Loading

Minimum PHP version

Minimum PHP version is with Nextcloud 16 PHP 7.1: #12021

Databases

Minimum PostgreSQL version was lifted to 9.5 nextcloud/documentation#1516

Removed from public namespace:

Hardening:

Deprecated shipping of javascript libraries:

The following libraries are considered as deprecated from Nextcloud 16 on. If you use one of those in your app, make sure to ship your own version that is properly bundled with your app:

Autoloading via appinfo/classpath.php

In the past it was also possible to autoload PHP classes in apps by specify a list of classes and filenames in appinfo/classpath.php. This should not be used anymore and also isn't used by any app that is publicly available. See #14442
@rullzer rullzer added this to the Nextcloud 16 milestone Dec 7, 2018
@rullzer rullzer mentioned this issue Dec 7, 2018
Merged
This was referenced Dec 7, 2018
Closed
Closed
@MorrisJobke MorrisJobke mentioned this issue Jan 3, 2019
Closed
1 task
@juliushaertl juliushaertl mentioned this issue Jan 10, 2019
Closed
@ChristophWurst ChristophWurst mentioned this issue Jan 10, 2019
Merged
kesselb added a commit that referenced this issue Jan 20, 2019
@kesselb
Clipboard -> ClipboardJS
b363404 
#12915
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@nickvergessen nickvergessen mentioned this issue Jan 24, 2019
Merged
@nickvergessen
Copy link
Member

nickvergessen commented Jan 28, 2019 •
edited
Loading

The old activity workarounds have been removed. Decent interfaces have been in place since Nextcloud 11.

kesselb added a commit that referenced this issue Feb 1, 2019
@kesselb
Clipboard -> ClipboardJS
0972a55 
#12915
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@MorrisJobke
Copy link
Member

Autoloading via appinfo/classpath.php

In the past it was also possible to autoload PHP classes in apps by specify a list of classes and filenames in appinfo/classpath.php. This should not be used anymore and also isn't used by any app that is publicly available. See #14442

@xf-
Copy link

xf- commented Apr 17, 2019 •
edited
Loading

Anything in oauth changed? won't work in 16 (PHP error and all integrations are failing)
Nextcloud as provider
e.g. config working in v15 https://github.com/hackmdio/codimd/blob/develop/docs/guides/auth/nextcloud.md

OK - maybe a bug:

[index] Error: TypeError: Argument 1 passed to OCA\OAuth2\Db\ClientMapper::getByUid() must be of the type int, string given, called in ...nextcloud/apps/oauth2/lib/Controller/OauthApiController.php on line 110 at <<closure>>

0. ...nextcloud/apps/oauth2/lib/Controller/OauthApiController.php line 110
   OCA\OAuth2\Db\ClientMapper->getByUid("2")
1. ...nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 166
   OCA\OAuth2\Controller\OauthApiController->getToken("*** sensitive parameters replaced ***")
2. ...nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 99
   OC\AppFramework\Http\Dispatcher->executeController(OCA\OAuth2\Contr ... {}, "getToken")
3. ...nextcloud/lib/private/AppFramework/App.php line 126
   OC\AppFramework\Http\Dispatcher->dispatch(OCA\OAuth2\Contr ... {}, "getToken")
4. ...nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
   OC\AppFramework\App::main("OCA\\OAuth2\\Co ... r", "getToken", OC\AppFramework\ ... {}, {_route: "oauth2.OauthApi.getToken"})
5. <<closure>>
   OC\AppFramework\Routing\RouteActionHandler->__invoke({_route: "oauth2.OauthApi.getToken"})
6. ...nextcloud/lib/private/Route/Router.php line 297
   undefinedundefinedcall_user_func(OC\AppFramework\ ... {}, {_route: "oauth2.OauthApi.getToken"})
7. ...nextcloud/lib/base.php line 975
   OC\Route\Router->match("/apps/oauth2/api/v1/token")
8. ...nextcloud/index.php line 42
   OC::handleRequest()

POST /apps/oauth2/api/v1/token

@rullzer
Copy link
Member Author

rullzer commented Apr 18, 2019

@xf- should not let me look into that

@xf-
Copy link

xf- commented Apr 18, 2019

@rullzer my first thought was - maybe somtehing changed. i was lazy and added a cast as temp solution

n-connect added a commit to n-connect/nextcloud-spreedme that referenced this issue Jan 26, 2020
@n-connect
Update security.php
f8c77e2 
Quick 'n dirty fix for Speed.ME app for Nextcloud works till NC16.x. This change needs PHP minimum 7.0.x, but in reality PP 7.1.x+ With HP 7.1.x you can use random_bytes() - appeared in 7.0, _and_ in NC16 the minimum version is PHP 7.1.x. From Nextcloud side from version 16 some PHP based NC functions has removed: nextcloud/server#12915.

Tested on NC16 instance, which continuously updated from NC13 or so. Works with multiple participants, no 4 participants limit, your resources the limit, contrary to Nextcloud Talk, which supports Signalling Servers, but not really does: nextcloud/spreed#2515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
overview
Projects
None yet
Milestone
Nextcloud 16
Development

No branches or pull requests
4 participants
@rullzer @nickvergessen @MorrisJobke @xf-