Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct editing should return an error if editor is not found #18240

Closed
juliushaertl opened this issue Dec 5, 2019 · 1 comment · Fixed by #18478
Closed

Direct editing should return an error if editor is not found #18240

juliushaertl opened this issue Dec 5, 2019 · 1 comment · Fixed by #18478
Assignees
@ChristophWurst
Labels
3. to review Waiting for reviews bug
Milestone
Nextcloud 18.0.0

Comments

@juliushaertl
Copy link
Member

When requesting a direct editing URL for an editor that is not found we should return an error instead of an url that then returns a 404 response

cc @tobiasKaminsky
@juliushaertl juliushaertl added bug 1. to develop Accepted and waiting to be taken care of labels Dec 5, 2019
@juliushaertl juliushaertl added this to the Nextcloud 18 milestone Dec 5, 2019
@juliushaertl juliushaertl self-assigned this Dec 5, 2019
@tobiasKaminsky
Copy link
Member

👍
Please add it then also to proper api documentation.

On Android side I already handle this ;-)

@ChristophWurst ChristophWurst added 2. developing Work in progress 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress labels Dec 19, 2019
@ChristophWurst ChristophWurst mentioned this issue Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging a pull request may close this issue.

Do not generate tokens for editor IDs that do not exist nextcloud/server
3 participants
@ChristophWurst @juliushaertl @tobiasKaminsky