Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate tokens for editor IDs that do not exist #18478

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Do not generate tokens for editor IDs that do not exist #18478

merged 2 commits into from
Dec 22, 2019

Conversation

ChristophWurst
Copy link
Member

Fixes #18240

Untested as I have no clue how to use this :D

@ChristophWurst
Do not generate tokens for editor IDs that do not exist
4ff11e3 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels Dec 19, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Dec 19, 2019
@ChristophWurst ChristophWurst self-assigned this Dec 19, 2019
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Dec 19, 2019
@rullzer rullzer mentioned this pull request Dec 19, 2019
Merged
18 tasks
@juliushaertl
Expose exception message in the response
0ddb9c0 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member

Pushed another small commit to actually show the exception message.

@juliushaertl
Copy link
Member

Steps to test:

  1. Have the text app installed (master branch)
  2. Create a file README.md
  3. Call the api endpoint:
curl -X POST 'https://admin:admin@nextcloud.local/ocs/v2.php/apps/files/api/v1/directEditing/open?path=/README.md&editorId=NOTEXISTING&format=json' -H 'OCS-APIRequest: true'

@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2019

Pushed another small commit to actually show the exception message.

We are not leaking any information with that?

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Dec 20, 2019
@tobiasKaminsky
Copy link
Member

Pushed another small commit to actually show the exception message.

We are not leaking any information with that?

I doubt so. You can get the list of available editorIds via another endpoint.
Also this endpoint is only reachable when authenticated.

@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2019

I doubt so. You can get the list of available editorIds via another endpoint.
Also this endpoint is only reachable when authenticated.

Thanks 👍 I restarted the build.

@rullzer rullzer merged commit 04031f6 into master Dec 22, 2019
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Dec 22, 2019
@rullzer rullzer deleted the fix/direct-editing-invalid-editor-id branch December 22, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@kesselb kesselb kesselb approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug
Projects
No open projects
Christoph's Tasks
DONE
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

Direct editing should return an error if editor is not found
5 participants
@ChristophWurst @juliushaertl @kesselb @tobiasKaminsky @rullzer