Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide download button when sharing with email #18318

Closed
jhesketh opened this issue Dec 10, 2019 · 5 comments
Closed

Add ability to hide download button when sharing with email #18318

jhesketh opened this issue Dec 10, 2019 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@jhesketh
Copy link

Is your feature request related to a problem? Please describe.
I can hide the download button for link shares, but not for shares made with email addresses.

Describe the solution you'd like
As a user, I would like to be able to hide the download button regardless of sharing method.

Describe alternatives you've considered
Only sharing by link. This would require me to send an email manually each time to the recipient. But it also makes cancelling links hard as I can't tell who I have shared what with.

@jhesketh jhesketh added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Dec 10, 2019
@wiswedel
Copy link
Contributor

@jhesketh Not sure if it was already possible in 17, but in 18 this is available.

@jhesketh
Copy link
Author

So I just checked and there is now a box to disable downloads for email shares (this was not there before, so must be new in 18 I think).

However, ticking the box does not work. On refresh of the page the box is always unticked. This is true for new and existing email based shares.

@wiswedel
Copy link
Contributor

However, ticking the box does not work. On refresh of the page the box is always unticked. This is true for new and existing email based shares.

That's indeed a harsh bug. Let me file a bug issue and reference it here.

@wiswedel
Copy link
Contributor

@jhesketh I found the bug already reported in #19484 (however described quite technical)

@jhesketh
Copy link
Author

Great, thanks for the followup :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

2 participants