Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trash on external files #18396

Open
christianlupus opened this issue Dec 13, 2019 · 0 comments
Open

Trash on external files #18396

christianlupus opened this issue Dec 13, 2019 · 0 comments

Comments

@christianlupus
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I have a big external storage with a huge amount of videos. Now remove such a big file (using NC).
According to my research the to-be-removed file will be moved to the trash folder of my current user and the file will be removed on the external storage. This has some draw-backs:

  1. The trash gets full quite quickly as the NC data partition is not too big.
  2. As a result all other trashed files get removed to free up space. This can cause other problems.
  3. The file needs to be copied from one partition to another. This might take significant time causing PHP to time out in worst case scenario.

Describe the solution you'd like
There could be a set of additional setting in the config of the external storage. Using these I can define how the trash in the external storage should be managed. Suggestions:

  • Keep the old behavior
  • Remove without trashing
  • Use a separate folder (on the external storage partition) as trash folder. This renders the copy/removal much more quick as it is a simple rename.
  • Use a dot folder in the root of the external storage to keep track of the files (but hide it from the NC UI of course)
@christianlupus christianlupus added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Dec 13, 2019
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of feature: external storage feature: trashbin and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants