Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Delete Confirmation Dialog #32011

Closed
HaziFlorinMarian opened this issue Apr 19, 2022 · 12 comments · Fixed by #43231
Closed

File Delete Confirmation Dialog #32011

HaziFlorinMarian opened this issue Apr 19, 2022 · 12 comments · Fixed by #43231

Comments

@HaziFlorinMarian
Copy link

Is your feature request related to a problem? Please describe.
When we right-click on the files we have the last two options from the "Download" and "Delete" list. It is very common for our users to click "Delete" instead of "Download" and the files are deleted directly.

Describe the solution you'd like
When we click on "Delete" a popup window will open asking us to confirm if we really want to delete.

Describe alternatives you've considered
The "Download" and "Delete" buttons are no longer below each other.

Additional context
It's not necessary.

@HaziFlorinMarian HaziFlorinMarian added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Apr 19, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 19, 2022

Cc @nimishavijay @jancborchardt

@killerbees19
Copy link

killerbees19 commented Jul 6, 2022

A confirmation dialog is as much more important if files_versions app is disabled!

Please implement such a feature at minimum as optional (configurable) setting.

@giang13297
Copy link

Hi Guys,
Any update for this feature.
Please!!!!

@delacosta456
Copy link

hi
i also want to request for this feature and mention that people have also requested for it on forums.
Is it also possible to rename the title of this feature request to something like "Confirmation Dialog for files & folder deletion"
Thanks

@nimishavijay
Copy link
Member

Interesting problem! One Drive and Dropbox have a confirmation dialogue for deleting files too. However, it seems intrusive to show a confirmation dialogue every time a file is deleted, since deletion is a common action. There is also a trash bin from which files can be recovered.

We could definitely move the "Download" action up. Another solution is to have a notification with an undo button, similar to sending a message in Mail. This is also the behaviour for Google Drive. So a notification Design review.md has been deleted. [Undo]. This would be my preferred solution as it is not as intrusive, and still offers a way to quickly cancel deletion if it was by mistake. What do you think? cc @jancborchardt and @szaimen as well

@szaimen
Copy link
Contributor

szaimen commented May 8, 2023

@nimishavijay I agrees that an undo popup would be the preferred solution in that case since showing a popup might be too intrusive and slow and as you said we have the trashbin for this case.

However maybe there could be a differentiation between folders and files? So that to show the popup for folders and/or if multi-selecting and then clicking on the delete option?

@killerbees19
Copy link

There is also a trash bin from which files can be recovered.

In some cases this feature is disabled, because it's nearly incompatible with external files storage and big files. (See #14436 or #18396)

@delacosta456
Copy link

delacosta456 commented May 9, 2023

hi @nimishavijay intrusive... truly and if your are talking about deleting multiple files, selecting concerned files/folder with check box method(already present) could present a single confirmation box about select items.
Also, i think Gmail has a setting to configure (enable) "Confirm before deleting.." may be implementing this (if possible) could let the user decide what is comfortable .

@skjnldsv
Copy link
Member

skjnldsv commented Jan 2, 2024

@nimishavijay @szaimen @jancborchardt
What about showing a confirm if you are deleting more than one file ?

That would be a sane compromise to move that issue forward I think? :)

@szaimen
Copy link
Contributor

szaimen commented Jan 3, 2024

@nimishavijay @szaimen @jancborchardt What about showing a confirm if you are deleting more than one file ?

That would be a sane compromise to move that issue forward I think? :)

Yes, sounds like a good solution to me :)

@jancborchardt
Copy link
Member

@skjnldsv yup, sounds like a good first step. :)

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 5, 2024
@skjnldsv skjnldsv self-assigned this Jan 5, 2024
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Jan 5, 2024
@skjnldsv skjnldsv added this to Legacy bugs in Files to vue via automation Jan 5, 2024
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2024
@skjnldsv skjnldsv moved this from Legacy bugs to In progress in Files to vue Jan 31, 2024
Files to vue automation moved this from In progress to Done Feb 7, 2024
@LMRW
Copy link

LMRW commented May 11, 2024

If trash & file versions are disabled (which sometimes is required) then being able to delete entire folders of terabytes of data in a single click without confirmation is a HUGE issue. Absolutely nextcloud should ask users if they are sure - every time - if trash can and versions are disabled. This is a massive massive massive usability issue with tremendous danger of incredible file loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Files to vue
  
Done
Archived in project
Development

Successfully merging a pull request may close this issue.

10 participants