Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User management view: Rethink table based layout for create / update #18561

Closed
kesselb opened this issue Dec 23, 2019 · 9 comments
Closed

User management view: Rethink table based layout for create / update #18561

kesselb opened this issue Dec 23, 2019 · 9 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: users and groups needs info stale Ticket or PR with no recent activity

Comments

@kesselb
Copy link
Contributor

kesselb commented Dec 23, 2019

Is your feature request related to a problem? Please describe.

nextcloud test_settings_users (3)

The user management view is unclear and confusing.

Describe the solution you'd like

I think we should not use a table based layout for create and update user. I would expect that edit user will increase the "row heigh" and shows a form with the available options below the user and above the next one. Similar to Mailcow (see additional context) list but with inline edit.

Additional context

demo pydio com_welcome_

Pydio uses a list and a dialog for editing

demo mailcow email_mailbox

Mailcow uses a list and plus button to show additional information. But a different page for edit.

@kesselb kesselb added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap 18-feedback labels Dec 23, 2019
@gary-kim
Copy link
Member

There's some work going on in #18455

@skjnldsv
Copy link
Member

for you @jancborchardt

@jancborchardt
Copy link
Member

The reason both the view and edit layout is the same is so people don't need to do a mental switch. When you have symmetry there, you immediately know what to edit.

It would be great if you can clarify what you mean by "unclear and confusing".

As for the inspiration, could you check with more widely used systems than Pydio and Mailcow, e.g. Google Suite or Basecamp? :)

@kesselb
Copy link
Contributor Author

kesselb commented Dec 29, 2019

As for the inspiration, could you check with more widely used systems than Pydio and Mailcow, e.g. Google Suite or Basecamp? :)

I don't have a Google Suite or Basecamp but we can check their docs:

Unfortunately only a small part of the interface is visible. But Office 365 has a detailed online documentation with videos.

I have to say well done Microsoft. That's easy to use and understand hence not confusing.

It would be great if you can clarify what you mean by "unclear and confusing".

You looked at the screenshot? 🤣

  1. There is a column password. It's only required for adding a user but takes space all the time.
  2. I'm used to fill forms from top to bottom. Every form works like that. Register for a service, Tax declaration, Report a issue on GitHub. Sometimes I have to use left to right. For example a attendee list: Id, Date and Signature. That works well for a few columns. Not if you have a lot of information.
  3. Ask yourself: Where is the save button for a new user? Ah you can use the arrow keys to navigate to the right to make it visible. Fair enough 1440 width is probably a bit small.
    image
  4. Additional columns can be shown. Isn't that already a warning sign the a interface is to complex?
  5. Create user button and exit edit mode button are using a different design language (excuse me if this is the wrong terminology) with the same list. The button to show the new user input list and create user button are the same. But that still looks weird.
    image
  6. Nothing wrong with that. But I always have a facepalm moment when looking at it ;)
    Peek 2019-12-29 17-37
  7. Yes. We can fix 3+4 by adding more CSS but I think that's the wrong track. People will ask for more features. For example the "send email to new user" checkbox is already gone (it was within the settings menu but missing now). But that's a popular feature and makes sense. Such a option should be checkable when creating a user. Not within a menu. I have the feeling that features are killed for a nice user interface.

When you have symmetry there, you immediately know what to edit.

image

It seems we don't have the same understanding of symmetry ;) The input for the display name is with the password column, password with the email column.

image

I think the owncloud view is less confusingly. User create form is not part of the user list. That's a clear separation.

@jancborchardt
Copy link
Member

jancborchardt commented Dec 30, 2019

Soo, that’s a lot of separate things and I agree on a lot of them and have proposals to fix them, as you can see from my design review previously at #17239 (comment), e.g.:

Stuff is a bit squished, especially the controls on the right? Having the controls sticky on the right would be much better to have them easily reachable without horizontal scrolling (which is a huge pain)

As the feedback points are so separate though, they should ideally be opened as separate issues. :) Could you do that? Feel free to also quote my points from the issue above in the relevant ones, and @-mention me for further input.


Also a simpler way of doing the "New user" form I commented at
#18455 (comment)

Also, if you notice, the new entry basically duplicates all of the header info. So instead of showing it below the heading, it could be shown instead of it. (Above via z-index.)


So yes, let’s absolutely simplify this, but not get ahead of ourselves. :) Small steps and small iterations.

@kesselb
Copy link
Contributor Author

kesselb commented Jan 1, 2020

they should ideally be opened as separate issues.

If you think so ;) Feel free to open it in a way that makes sense.

@gary-kim
Copy link
Member

gary-kim commented Feb 16, 2020

Came up earlier. This is what I see in Google Admin for GSuite.
Screenshot_2020-02-17 User List - Admin Console

@szaimen
Copy link
Contributor

szaimen commented Jun 7, 2021

At least the creation dialog was put into a modal in NC22.
Though editing isn't changed, yet.
Do we want to leave this issue open or do we want to create a new one for the rest?

@ghost
Copy link

ghost commented Jul 7, 2021

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale Ticket or PR with no recent activity label Jul 7, 2021
@ghost ghost closed this as completed Jul 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: users and groups needs info stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

6 participants