fix userlist alignment

[GretaD]

Fixes #18420

• fix userlist alignment
• add a close button for new user list
• action buttons should be sticky

[GretaD]

@skjnldsv @nextcloud/designers how we should move on with the new user list? I did a small change and now it look like this:

I am aware of the overlapping and maybe we should make the borders thicker to make it look like a sticky list over the existing list?

[skjnldsv]

I'm ok with this.
what do you think @jancborchardt

[jancborchardt]

Nice @GretaD!

I am aware of the overlapping and maybe we should make the borders thicker to make it look like a sticky list over the existing list?

Can you fix that overlapping? The borders should always be only 1px, we never use thicker borders. It’s fine if it’s just sticky as it is. :)

Also, if you notice, the new entry basically duplicates all of the header info. So instead of showing it below the heading, it could be shown instead of it. (Above via z-index.)

And can you add the close button you mentioned? Next to the "Add" button on the right, just like when editing an existing user

[jancborchardt]

See comment :)

[GretaD]

@jancborchardt i would say that the add new user table should be somehow visually splitted from the existing users. But yes, let me try out your proposal and see how it looks.

[GretaD]

Can you fix that overlapping? The borders should always be only 1px, we never use thicker borders. It’s fine if it’s just sticky as it is. :)

what do you think? ;)

[rullzer]

master is NC19 now.
Please backport if it needs to go into 18

[jancborchardt]

@GretaD is this now ready for review? :)

[GretaD]

@m4dz i cannot add you as a reviewer but this is the full PR of what we were working :)

[georgehrke]

Looks good besides my comments

[jancborchardt]

• "Done" button should also be primary so you know what to do next
• On editing an entry, the action buttons are too much to the right, with the 3-dot-menu being cut off half
• How do you cancel editing a user? On editing, the 3-dot-menu should change to an X cancel icon.

[GretaD]

* [ ]  "Done" button should also be primary so you know what to do next

I'll open a new ticket for this one and will work on it next week.

* [x]  On editing an entry, the action buttons are too much to the right, with the 3-dot-menu being cut off half

Done

* [ ]  How do you cancel editing a user? On editing, the 3-dot-menu should change to an X cancel icon.

I'll open a new ticket for this one and will work on it next week.

[juliushaertl]

Suggested change

	let quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({
	const quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({

[juliushaertl]

Eslint fails and bundles need to be recompiled

[juliushaertl]

Fixed eslint, css indent and pushed bundles