fix userlist alignment #18455

GretaD · 2019-12-17T22:26:50Z

fix userlist alignment
add a close button for new user list
action buttons should be sticky

GretaD · 2019-12-17T22:31:36Z

@skjnldsv @nextcloud/designers how we should move on with the new user list? I did a small change and now it look like this:

I am aware of the overlapping and maybe we should make the borders thicker to make it look like a sticky list over the existing list?

skjnldsv · 2019-12-19T09:45:07Z

I'm ok with this.
what do you think @jancborchardt

jancborchardt · 2019-12-24T10:51:20Z

Nice @GretaD!

I am aware of the overlapping and maybe we should make the borders thicker to make it look like a sticky list over the existing list?

Can you fix that overlapping? The borders should always be only 1px, we never use thicker borders. It’s fine if it’s just sticky as it is. :)

Also, if you notice, the new entry basically duplicates all of the header info. So instead of showing it below the heading, it could be shown instead of it. (Above via z-index.)

And can you add the close button you mentioned? Next to the "Add" button on the right, just like when editing an existing user

jancborchardt

See comment :)

GretaD · 2020-01-06T11:40:49Z

@jancborchardt i would say that the add new user table should be somehow visually splitted from the existing users. But yes, let me try out your proposal and see how it looks.

GretaD · 2020-01-06T12:44:32Z

Can you fix that overlapping? The borders should always be only 1px, we never use thicker borders. It’s fine if it’s just sticky as it is. :)

what do you think? ;)

rullzer · 2020-01-09T07:07:04Z

master is NC19 now.
Please backport if it needs to go into 18

jancborchardt · 2020-01-13T22:33:03Z

@GretaD is this now ready for review? :)

GretaD · 2020-01-14T19:20:43Z

@m4dz i cannot add you as a reviewer but this is the full PR of what we were working :)

georgehrke

Looks good besides my comments

apps/settings/css/settings.scss

apps/settings/src/components/UserList.vue

jancborchardt · 2020-01-15T23:31:42Z

"Done" button should also be primary so you know what to do next
On editing an entry, the action buttons are too much to the right, with the 3-dot-menu being cut off half
How do you cancel editing a user? On editing, the 3-dot-menu should change to an X cancel icon.

GretaD · 2020-01-16T14:31:44Z

* [ ]  "Done" button should also be primary so you know what to do next

I'll open a new ticket for this one and will work on it next week.

* [x]  On editing an entry, the action buttons are too much to the right, with the 3-dot-menu being cut off half

Done

* [ ]  How do you cancel editing a user? On editing, the 3-dot-menu should change to an X cancel icon.

I'll open a new ticket for this one and will work on it next week.

juliushaertl · 2020-01-16T18:53:12Z

apps/settings/src/components/UserList.vue

@@ -336,9 +344,9 @@ export default {
 		},
 		quotaOptions() {
 			// convert the preset array into objects
-			const quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({
+			let quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({


Suggested change

let quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({

const quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({

Eslint fails and bundles need to be recompiled

Signed-off-by: GretaD <gretadoci@gmail.com>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliushaertl · 2020-01-16T19:24:13Z

Fixed eslint, css indent and pushed bundles

gary-kim added 2. developing Work in progress bug design Design, UI, UX, etc. labels Dec 18, 2019

gary-kim added this to the Nextcloud 18 milestone Dec 18, 2019

This was referenced Dec 19, 2019

18 beta 3 #18370

Merged

18 beta 4 #18480

Merged

skjnldsv added the help wanted label Dec 19, 2019

gary-kim mentioned this pull request Dec 24, 2019

User management view: Rethink table based layout for create / update #18561

Closed

rullzer mentioned this pull request Dec 27, 2019

18 RC 1 #18578

Merged

13 tasks

jancborchardt requested review from skjnldsv, gary-kim and jancborchardt December 30, 2019 06:40

jancborchardt requested changes Dec 30, 2019

View reviewed changes

rullzer mentioned this pull request Jan 2, 2020

18 RC 2 #18639

Merged

1 task

GretaD requested a review from jancborchardt January 8, 2020 10:55

rullzer modified the milestones: Nextcloud 18, Nextcloud 19 Jan 9, 2020

GretaD force-pushed the feature/18420/new-user-alignment branch from e054640 to 97e9706 Compare January 9, 2020 16:11

GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 9, 2020

GretaD force-pushed the feature/18420/new-user-alignment branch from 97e9706 to 2556e9b Compare January 13, 2020 16:31

GretaD added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 14, 2020

GretaD requested review from juliushaertl and georgehrke January 14, 2020 19:17

GretaD added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 14, 2020

georgehrke requested changes Jan 14, 2020

View reviewed changes

GretaD requested a review from georgehrke January 15, 2020 16:37

GretaD force-pushed the feature/18420/new-user-alignment branch from f8fd0a0 to f65a72f Compare January 16, 2020 13:01

juliushaertl approved these changes Jan 16, 2020

View reviewed changes

juliushaertl reviewed Jan 16, 2020

View reviewed changes

GretaD and others added 9 commits January 16, 2020 20:12

fix userlist alignment

99a64e7

Signed-off-by: GretaD <gretadoci@gmail.com>

fix new user table

b5f4146

Signed-off-by: GretaD <gretadoci@gmail.com>

add close button

a958eac

Signed-off-by: GretaD <gretadoci@gmail.com>

make actionButton sticky

5fa31f1

Signed-off-by: GretaD <gretadoci@gmail.com>

fix popover menu overlapping

0428140

Signed-off-by: GretaD <gretadoci@gmail.com>

fix indentation and 3 dot menu

0cff56b

Signed-off-by: GretaD <gretadoci@gmail.com>

Fix eslint errors in settings

011d70d

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix indentation

c9a17f3

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Bump bundles

a9c224c

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliushaertl force-pushed the feature/18420/new-user-alignment branch from e835905 to a9c224c Compare January 16, 2020 19:20

georgehrke approved these changes Jan 16, 2020

View reviewed changes

rullzer merged commit c9acba1 into master Jan 16, 2020

rullzer deleted the feature/18420/new-user-alignment branch January 16, 2020 22:24

juliushaertl mentioned this pull request Jan 16, 2020

[stable18] fix userlist alignment #18947

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix userlist alignment #18455

fix userlist alignment #18455

GretaD commented Dec 17, 2019 •

edited

Loading

GretaD commented Dec 17, 2019

skjnldsv commented Dec 19, 2019

jancborchardt commented Dec 24, 2019

jancborchardt left a comment

GretaD commented Jan 6, 2020

GretaD commented Jan 6, 2020

rullzer commented Jan 9, 2020

jancborchardt commented Jan 13, 2020

GretaD commented Jan 14, 2020

georgehrke left a comment •

edited

Loading

jancborchardt commented Jan 15, 2020 •

edited by GretaD

Loading

GretaD commented Jan 16, 2020

juliushaertl Jan 16, 2020

juliushaertl Jan 16, 2020

juliushaertl commented Jan 16, 2020

	let quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({
	const quotaPreset = this.settings.quotaPreset.reduce((acc, cur) => acc.concat({

fix userlist alignment #18455

fix userlist alignment #18455

Conversation

GretaD commented Dec 17, 2019 • edited Loading

GretaD commented Dec 17, 2019

skjnldsv commented Dec 19, 2019

jancborchardt commented Dec 24, 2019

jancborchardt left a comment

Choose a reason for hiding this comment

GretaD commented Jan 6, 2020

GretaD commented Jan 6, 2020

rullzer commented Jan 9, 2020

jancborchardt commented Jan 13, 2020

GretaD commented Jan 14, 2020

georgehrke left a comment • edited Loading

Choose a reason for hiding this comment

jancborchardt commented Jan 15, 2020 • edited by GretaD Loading

GretaD commented Jan 16, 2020

juliushaertl Jan 16, 2020

Choose a reason for hiding this comment

juliushaertl Jan 16, 2020

Choose a reason for hiding this comment

juliushaertl commented Jan 16, 2020

GretaD commented Dec 17, 2019 •

edited

Loading

georgehrke left a comment •

edited

Loading

jancborchardt commented Jan 15, 2020 •

edited by GretaD

Loading