Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User menu and contacts menu are missing triangle indicators #18606

Closed
jancborchardt opened this issue Dec 30, 2019 · 2 comments · Fixed by #18615
Closed

User menu and contacts menu are missing triangle indicators #18606

jancborchardt opened this issue Dec 30, 2019 · 2 comments · Fixed by #18615
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
Nextcloud 18.0.0

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Dec 30, 2019 •
edited
Loading

Before: Nice triangle indicator as we do elsewhere with all menus and especially with the header to have a sense of space:
user menu old

In master: The triangle is missing? This is both for the user menu and contacts menu.
Also the animation seems to come in from the right which does not really make a lot of sense – it should come in from above only.
avatar menu

cc @nextcloud/designers
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of labels Dec 30, 2019
@jancborchardt
Copy link
Member Author

Same issue for the "More" apps menu and the notifications menu actually. What happened here? :D

@jancborchardt jancborchardt added this to the Nextcloud 18 milestone Dec 31, 2019
@juliushaertl
Copy link
Member

Seems to be a regression of #16057 I'll have a look

@juliushaertl juliushaertl self-assigned this Dec 31, 2019
@juliushaertl juliushaertl mentioned this issue Dec 31, 2019
Merged
@juliushaertl juliushaertl removed their assignment Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging a pull request may close this issue.

Move scroll container to inner element nextcloud/server
3 participants
@jancborchardt @wiswedel @juliushaertl