Move scroll container to inner element #18615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
added
bug
design
juliushaertl
requested review from
rullzer,
jancborchardt,
skjnldsv and
danxuliu
jancborchardt
approved these changes
Jan 2, 2020
skjnldsv
approved these changes
Jan 2, 2020
|
Greeeen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18606
To be tested together with nextcloud/notifications#528
Reverts the approach from #16057 since using the wrapper menu element as a scroll container caused #18606. We now use the inner element to scroll but need to specify the same min-/max-height for both the wrapping and containing element. Otherwise the inner element would not adjust to the height properly.