Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CardDAV image export broken for Mail #1992

Closed
ChristophWurst opened this issue Nov 3, 2016 · 2 comments
Closed

CardDAV image export broken for Mail #1992

ChristophWurst opened this issue Nov 3, 2016 · 2 comments
Assignees
@LukasReschke
Labels
bug high regression
Milestone
Nextcloud 11.0.1

Comments

@ChristophWurst
Copy link
Member

The image export plugin we use in Mail to show contact images is broken since #1339.

Apparently, removing the Content-Disposition header fixes the problem. ref #1339 (comment)

cc @LukasReschke

ref nextcloud/mail#131
@ChristophWurst ChristophWurst added this to the Nextcloud 11.0 milestone Nov 3, 2016
@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of labels Nov 3, 2016
@ChristophWurst
Copy link
Member Author

@LukasReschke how could this be fixed?

@ChristophWurst ChristophWurst mentioned this issue Dec 8, 2016
Closed
LukasReschke added a commit that referenced this issue Dec 14, 2016
@LukasReschke
Don't set Content-Disposition header if one already exists
8a00638 
If a Content-Disposition header is already set by another plugin we don't need to set another one as this breaks clients.

Fixes #1992

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke mentioned this issue Dec 14, 2016
Merged
@LukasReschke
Copy link
Member

Patch is at #2677

nickvergessen pushed a commit that referenced this issue Jan 5, 2017
@LukasReschke @nickvergessen
Don't set Content-Disposition header if one already exists
adef282 
If a Content-Disposition header is already set by another plugin we don't need to set another one as this breaks clients.

Fixes #1992

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@MorrisJobke MorrisJobke removed the 1. to develop Accepted and waiting to be taken care of label Feb 21, 2017
@snyk-bot snyk-bot mentioned this issue May 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasReschke LukasReschke

Labels
bug high regression
Projects
None yet
Milestone
Nextcloud 11.0.1
Development

No branches or pull requests
5 participants
@nickvergessen @MorrisJobke @LukasReschke @jancborchardt @ChristophWurst