More contextually relevant button labels

[jancborchardt]

For example in the case of this modal:

The button labels »Yes« and »No« are pretty stupid. Instead the »Yes« button should say »Yes, add trusted domain«.

@nickvergessen since you said the JS only has these options, we should make it possible to pass custom labels which make more sense than a stupid »Yes«, »No« and »OK«.

cc @nextcloud/designers @nextcloud/javascript

[skjnldsv]

Also fix the translation? "Are you really sure that you want to add..."?

[comradekingu]

To me it seems odd to repeat the notion of adding.

Edit: I think just the http part should be orange, if that is meant to signal some kind of danger.

[jancborchardt]

Well, still the button should not say only "Yes" and the content could be a tad more verbose:

Add https://… as trusted domain?

Yes, trust this domain

[nickvergessen]

The button description is hackable atm:

server/core/js/js.js

Lines 1706 to 1713 in 086ce70

	).then(function() {
	var $dialog = $('.oc-dialog:visible');
	$dialog.find('.ui-icon').remove();
	var $buttons = $dialog.find('button');
	$buttons.eq(0).text(t('core', 'Cancel'));
	$buttons.eq(1).text(t('core', 'Confirm'));
	});

But yeah maybe some JS expert rewrites our Dialogs into something that also allows to provide the button labels directly.

[szaimen]

I think this is already implemented at many places -> closing.