Color the trusted domain to alert the admin a bit more

[nickvergessen]

@LukasReschke @rullzer

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @jancborchardt and @tanghus to be potential reviewers.

[schiessle]

Hm, the crucial question for me is, whether we really want to have a confirm dialog for every trusted server the admin adds? I tend to say no.

Cc @jancborchardt

[LukasReschke]

Hm, the crucial question for me is, whether we really want to have a confirm dialog for every trusted server the admin adds? I tend to say no.

This is for trusted domains for the trusted domain check. Nothing to do with federated sharing or whatsoever. There it is required. Because you basically click the "Add trusted domain" button and get redirected to this. (i.e. you type nothing)

Also the alert box isn't anything new. It's simply the styling.

[schiessle]

Ah, OK.... mixed this up. Then it makes sense. (Beside the stupid "!" at the front of the dialog, but I assume that this is a general issue and out of scope for this PR) 👍

[rullzer]

LGTM

[jancborchardt]

Btw @nickvergessen can we have the button be more contextually relevant here?

Yes shoud be: »Yes, add trusted domain«x

[nickvergessen]

No, the JS thing only has options yes-no and ok

[jancborchardt]

@nickvergessen well, then it’s of course a request that we should fix it. Opened an issue at #2104 ;)