Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App-navigation without settings should not have padding-bottom #2189

Closed
jancborchardt opened this issue Nov 17, 2016 · 1 comment · Fixed by #2283
Closed

App-navigation without settings should not have padding-bottom #2189

jancborchardt opened this issue Nov 17, 2016 · 1 comment · Fixed by #2283
Labels
bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
Nextcloud 11.0

Comments

@jancborchardt
Copy link
Member

Since #app-settings is inside #app-navigation, we can not do this via CSS. We probably need to add a class ».without-app-settings« to the #app-navigation via JS when there’s no settings, and then via CSS:

#app-navigation.without-app-settings {
   padding-bottom: 0;
}

capture du 2016-11-17 18-40-15

cc @BernhardPosselt @nextcloud/designers @nextcloud/javascript
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Nov 17, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Nov 17, 2016
@jancborchardt jancborchardt mentioned this issue Nov 17, 2016
Merged
MorrisJobke added a commit that referenced this issue Nov 23, 2016
@MorrisJobke
Remove padding from apps navigation if there is no settings area
51b7d04 
* fixes #2189

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke mentioned this issue Nov 23, 2016
Merged
@MorrisJobke
Copy link
Member

Fix is in #2283

@MorrisJobke MorrisJobke removed the 1. to develop Accepted and waiting to be taken care of label Nov 23, 2016
@nextcloud-bot nextcloud-bot mentioned this issue Jun 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging a pull request may close this issue.

Remove padding from apps navigation if there is no settings area nextcloud/server
2 participants
@MorrisJobke @jancborchardt