Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept shares, show pending shares on top of view #2192

Open
jancborchardt opened this issue Nov 17, 2016 · 10 comments
Open

Accept shares, show pending shares on top of view #2192

jancborchardt opened this issue Nov 17, 2016 · 10 comments

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Nov 17, 2016

The pending shares should show on top of the files view, without the need for yet another sidebar entry.
Incoming should be at the top, and rejected ones sorted at the bottom and greyed out. That way you can also get rejected shares back.

For incoming shares you can accept or reject them, and for rejected shares you can re-accept (undo rejection) or permanently delete. (Otherwise you’re stuck with a »pending shares« section for longer than you want.)

cc @nickvergessen @schiessle

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of enhancement feature: sharing high labels Nov 17, 2016
@jancborchardt jancborchardt added this to the Nextcloud 12.0 milestone Nov 17, 2016
@nickvergessen
Copy link
Member

Sounds good to me

@ghost
Copy link

ghost commented Mar 14, 2017

We would like that too!

@MorrisJobke
Copy link
Member

@schiessle @jancborchardt @karlitschek We should have this in our list for 13.

@karlitschek
Copy link
Member

agreed!

@jancborchardt
Copy link
Member Author

A higher priority is the general shares overview page: #5559

There we can simply show the pending shares up top, without the need for yet another sidebar entry.

@GioInside
Copy link

Hi, IMHO that function is not only a enhancement, but it's also a security issue because without this feature (current behaviour) if someone share something to me, desktop client will download that file without my approvation, and IMHO it's a potential way for malware propagation. Is it wrong?

@jospoortvliet
Copy link
Member

@GioInside only if it is from a user on your server. Not if it is a remote share, those you have to accept first, so I think this is, security-wise, done right already.

@skjnldsv skjnldsv changed the title Accept shares + overview page of pending+rejected shares Accept shares + overview page of pending + rejected shares Jul 23, 2018
@rullzer rullzer removed this from the Nextcloud 15 milestone Nov 5, 2018
@jancborchardt jancborchardt changed the title Accept shares + overview page of pending + rejected shares Accept shares, show pending shares on top of view, and have separate page for rejected shares Dec 21, 2018
@jancborchardt jancborchardt added this to the Nextcloud 16 milestone Dec 21, 2018
@jancborchardt jancborchardt changed the title Accept shares, show pending shares on top of view, and have separate page for rejected shares Accept shares, show pending shares on top of view Dec 21, 2018
@MorrisJobke MorrisJobke removed this from the Nextcloud 16 milestone Feb 25, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 17 milestone Feb 25, 2019
@MorrisJobke
Copy link
Member

Let's move it to 17.

@tobiasKaminsky
Copy link
Member

So…how we gonna do this?
Is this a separate endpoint, which needs to be called all the time? Or only when showing root folder?

(calling this all the time is, at least on Mobile, not a good solution, as we already have too many calls).

@jancborchardt
Copy link
Member Author

Also ref #27704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Enhancements
Development

No branches or pull requests

9 participants