External storage: Unneccesary menu entries

[ne20002]

Steps to reproduce

1. I have the external storage app and use it to have the user data stored on an usb disk.
2. I don't allow users to mount their own external storage

Expected behaviour

The users don't see the menu entries for external storage

Actual behaviour

Users have a menu entry for extenal storage, but they can't mount any external storage, it just displays an error message.

Server configuration

Operating system:
Raspbian OS
Web server:
Apache
Database:
mysql/mariadb
PHP version:
php-fpm 7.3
Nextcloud version: (see Nextcloud admin page)
20.0.4

[kesselb]

I don't consider this a bug. If the files_external app is enabled the menu item is registered.

The users don't see the menu entries for external storage

To achieve this each time the menu is generated we need to check if the current user is allowed to mount external storages or if there is an external storage using global credentials.

it just displays an error message.

And your users are confused about this one? We may improved the wording and yeah it looks a bit weird.

I think we can improve the look a bit if we add the above part also to the error view and make the error message a bit more explaining. cc @jancborchardt

[ne20002]

I see this as two elements

• the admin page (the first picture)
• the users page (second picture)

It's also seperated like this for the admin. If the checkbox 'Benutzern erlauben, externen Speicher einzubinden' is not selected, the second one should not appear. It's not a user specific configuration.
It should be ok to check this once on session start. Even if the admin allows this during a user session, it would be sufficiant to have this on the next login only.

Or mayby it may be seen like two seperate apps. Like is an admin adds or removes an app. That's where the menu entry needs to be checked only.

[kesselb]

If the checkbox 'Benutzern erlauben, externen Speicher einzubinden' is not selected, the second one should not appear.

Why not?

[ne20002]

Ain't it useless? What sense would it make to display only an error message and a useless option to enter credentials to be used for ... nothing?

[kesselb]

Good first issue Design changes: #24937 (comment)

Fine by me to hide the external storage app for users if the current user is not allowed to mount external storages and there is no external storage (the user has access to) using global credentials. Pull requests are always welcome.