Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Federated sharing cannot open a shared file #31896

Closed
4 of 8 tasks
Raudius opened this issue Apr 8, 2022 · 7 comments · Fixed by #31934
Closed
4 of 8 tasks

[Bug]: Federated sharing cannot open a shared file #31896

Raudius opened this issue Apr 8, 2022 · 7 comments · Fixed by #31934
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 24-feedback Feedback from 24.x releases bug regression

Comments

@Raudius
Copy link
Contributor

Raudius commented Apr 8, 2022

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Integration tests failing on richdocuments for federated sharing. Failing specifically on steps related to opening files shared accross instances.

Failing CI on richdocuments/master:
https://github.com/nextcloud/richdocuments/runs/5853738007

git bisect suggests originating commit is 44a8ebdc1fa796d4f7dc453c58561b64902ca12f from PR:
#31773

Steps to reproduce

Still working on reproducing it on the web environment.

Expected behavior

Opening of files shared across instances should work

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Enabled:
  - accessibility: 1.10.0
  - cloud_federation_api: 1.7.0
  - comments: 1.14.0
  - contactsinteraction: 1.5.0
  - dashboard: 7.4.0
  - dav: 1.22.0
  - federatedfilesharing: 1.14.0
  - federation: 1.14.0
  - files: 1.19.0
  - files_sharing: 1.16.0
  - files_trashbin: 1.14.0
  - files_versions: 1.17.0
  - lookup_server_connector: 1.12.0
  - oauth2: 1.12.0
  - provisioning_api: 1.14.0
  - richdocuments: 6.0.0-dev.1
  - settings: 1.6.0
  - sharebymail: 1.14.0
  - systemtags: 1.14.0
  - theming: 1.15.0
  - twofactor_backupcodes: 1.13.0
  - updatenotification: 1.14.0
  - user_status: 1.4.0
  - viewer: 1.8.0
  - weather_status: 1.4.0
  - workflowengine: 2.6.0
Disabled:
  - admin_audit
  - bruteforcesettings
  - encryption
  - files_external
  - testing
  - user_ldap

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@Raudius Raudius added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap regression labels Apr 8, 2022
@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of 24-feedback Feedback from 24.x releases and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 8, 2022
@PVince81
Copy link
Member

PVince81 commented Apr 8, 2022

@icewind1991 please have a look, it's related to the recent perf improvements.

I wonder if it's similar to #31858

@PVince81
Copy link
Member

PVince81 commented Apr 8, 2022

@Raudius we've merged a fix on master #31901

can you rerun the integration tests of richdocuments to confirm whether this also fixes that issue ?
if yes, you can close this ticket 😄

@Raudius
Copy link
Contributor Author

Raudius commented Apr 11, 2022

@icewind1991

Federattion tests are still not fixed on richdocuments :(

@PVince81 PVince81 assigned icewind1991 and unassigned Raudius Apr 11, 2022
@PVince81
Copy link
Member

@Raudius can you post instructions how to run that specific test locally ?

@Raudius
Copy link
Contributor Author

Raudius commented Apr 11, 2022

Pre-requisiites:

Then:

cd /var/www/html/apps/richdocuments/tests
sudo -u \#33 -- ./run-integration.sh ./features/federation.feature

@icewind1991
Copy link
Member

Pre-requisiites:

  • user admin setup with password password

@icewind1991
Copy link
Member

should be fixed with #31934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 24-feedback Feedback from 24.x releases bug regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants