Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem setup tweaks #31901

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Filesystem setup tweaks #31901

merged 3 commits into from
Apr 8, 2022

Conversation

icewind1991
Copy link
Member

  • Fix cached mountpoints without mount provider set being removed when getting a file by fileid (fixes [Bug]: Mountpoints of Collectives app no longer initialized on all requests #31858)

  • Always perform a full setup when loading the home folder with submounts included

    This does undo some of the performance improvements when a user has unused mount providers (i.e. groupfolders enabled, but the none configured) but does improve the reliability of handing apps that aren't adjusted to emit the events to refresh the cached mounts. Further tweaking can be done in the future

Might also #31896 but I don't have the setup to run the richdocuments integration tests atm

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 8, 2022
@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Apr 8, 2022
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz, come-nc and CarlSchwan and removed request for a team April 8, 2022 13:29
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense. getById would not work otherwise

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 8, 2022
@PVince81 PVince81 merged commit 1b819b8 into master Apr 8, 2022
@PVince81 PVince81 deleted the fs-setup-tweaks branch April 8, 2022 15:47
@blizzz blizzz mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mountpoints of Collectives app no longer initialized on all requests
3 participants