Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs have wrong border color with theming #3211

Closed
nickvergessen opened this issue Jan 23, 2017 · 10 comments
Closed

Inputs have wrong border color with theming #3211

nickvergessen opened this issue Jan 23, 2017 · 10 comments
Assignees
Labels

Comments

@nickvergessen
Copy link
Member

bildschirmfoto vom 2017-01-23 14-18-26

E.g. on the calendar.

Problem is the the border-color is not adjusted:

bildschirmfoto vom 2017-01-23 14-19-42

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Jan 23, 2017
@nickvergessen
Copy link
Member Author

Similar issue with buttons.
E.g. when you create a new calendar and hover the "Create" button

@skjnldsv
Copy link
Member

It will be fixed after we implemented the correct scss variable system for theming (see #2288 )

@skjnldsv skjnldsv self-assigned this Jan 23, 2017
@skjnldsv skjnldsv added feature: scss 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 23, 2017
@nickvergessen
Copy link
Member Author

Also checkboxes are two-colored:

bildschirmfoto vom 2017-01-25 11-08-21

@skjnldsv
Copy link
Member

yes, same thing :)

@nickvergessen
Copy link
Member Author

Also affecting radio buttons:

admin_-foobar-_2017-03-06_11 33 02

Also a different issue, but I guess variables PR might solve it as well:

bildschirmfoto vom 2017-03-06 11-33-28

@MorrisJobke
Copy link
Member

Fixed in #3530

@nickvergessen
Copy link
Member Author

I just pulled on master and the issues still exist

@nickvergessen nickvergessen reopened this Mar 21, 2017
@skjnldsv
Copy link
Member

@juliushaertl :)

@juliushaertl
Copy link
Member

juliushaertl commented Mar 24, 2017

@nickvergessen @MorrisJobke #3530 was just the first step, all the theming related stuff is addressed in #3531

@MorrisJobke
Copy link
Member

#3531 was merged and the input border worked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants