Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with custom color and dark theme #10457

Closed
violoncelloCH opened this issue Jul 30, 2018 · 8 comments
Closed

issues with custom color and dark theme #10457

violoncelloCH opened this issue Jul 30, 2018 · 8 comments
Assignees
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: theming
Milestone

Comments

@violoncelloCH
Copy link
Member

Steps to reproduce

  1. activate dark theme
  2. change color in theming and see dark theme being disabled temporarly
  3. go back to files and see only folder icons in new color, top bar in nextcloud blue and dark theme being applied in a strange way (see screenshot)
    grafik

Server configuration

Nextcloud version: NC 14.0.0 beta1

Updated from an older Nextcloud/ownCloud or fresh install: updated

Client configuration

Browser: Firefox

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #7401 (Theming on light color), #3211 (Inputs have wrong border color with theming), #4896 (Search results and theme color), #7071 (Missing icons at custom theme-color (Theming-App)), and #4137 (Custom location for themes).

@nickvergessen
Copy link
Member

A hard refresh is needed and should do the trick.

Seems like we are missing an increment on the scss version variable?

@violoncelloCH
Copy link
Member Author

@nickvergessen what kind of hard refresh do you mean? - a browser refresh dosen't help

after re-setting a different color with dark theme disabled, the top bar stays nextcloud-blue

@violoncelloCH
Copy link
Member Author

ahh, without having dark theme enabled, adding an app which places an icon in the top bar did the refresh, but this doesn't work for dark theme

@rullzer
Copy link
Member

rullzer commented Jul 31, 2018

@nextcloud/theming

@juliushaertl
Copy link
Member

We need to inject variables that come from the OCP\Defaults class in the accessibility app as well https://github.com/nextcloud/server/blob/master/apps/accessibility/lib/Controller/AccessibilityController.php#L144

similar to

$this->getInjectedVariables() .

cc @skjnldsv

@rullzer rullzer added this to the Nextcloud 14 milestone Aug 1, 2018
This was referenced Aug 8, 2018
@skjnldsv skjnldsv self-assigned this Aug 15, 2018
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 15, 2018
@skjnldsv
Copy link
Member

Fix in #10689

@violoncelloCH
Copy link
Member Author

violoncelloCH commented Aug 26, 2018

for me this issue still exists in RC1
it looks still the same as in the screenshot I posted
related to or same as #10960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: theming
Projects
None yet
Development

No branches or pull requests

6 participants