Argument 3 passed to `OCA\Files\Service\TagService::__construct()` must be an instance of `OCP\ITags` #3376

LukasReschke · 2017-02-04T17:42:24Z

{
  "reqId": "gBLN4PFTZ9eL4usiGOyB",
  "level": 3,
  "user": "--",
  "app": "index",
  "method": "GET",
  "url": "/apps/files/api/v1/showgridview",
  "message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /nextcloud/apps/files/lib/AppInfo/Application.php on line 106",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0",
  "version": "22.2.6.2",
  "exception": {
    "Exception": "TypeError",
    "Message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /nextcloud/apps/files/lib/AppInfo/Application.php on line 106",
    "Code": 0,
    "Trace": [
      {
        "file": "/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 106,
        "function": "__construct",
        "class": "OCA\\Files\\Service\\TagService",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\User\\Session"
          },
          {
            "__class__": "OC\\Activity\\Manager"
          },
          null,
          null,
          {
            "__class__": "OC\\EventDispatcher\\SymfonyAdapter"
          }
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 160,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 127,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 454,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 432,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 56,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 86,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "OCA\\Files\\Service\\TagService"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 160,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 127,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 454,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 432,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/nextcloud/lib/private/AppFramework/App.php",
        "line": 129,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": [
          "APIController"
        ]
      },
      {
        "file": "/nextcloud/lib/private/Route/Router.php",
        "line": 302,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "APIController",
          "getGridView",
          "*** sensitive parameter replaced ***",
          {
            "_route": "files.API.getGridView"
          }
        ]
      },
      {
        "file": "/nextcloud/lib/base.php",
        "line": 1006,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/apps/files/api/v1/showgridview"
        ]
      },
      {
        "file": "/nextcloud/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::",
        "args": []
      }
    ],
    "File": "/nextcloud/apps/files/lib/Service/TagService.php",
    "Line": 59,
    "CustomMessage": "--"
  },
  "id": "62979599b2973"
}

The text was updated successfully, but these errors were encountered:

LukasReschke · 2017-02-04T17:54:58Z

@nickvergessen Idea what could cause this? https://github.com/nextcloud/server/blob/v11.0.1/apps/files/lib/AppInfo/Application.php#L88

ChristophWurst · 2017-02-06T11:22:40Z

There's a condition where no ITags object is returned: when there's no current user

server/lib/private/TagManager.php

Lines 83 to 86 in fa96b9e

    
           if ($user === null) { 
        
           	// nothing we can do without a user 
        
           	return null; 
        
           }

LukasReschke · 2017-02-06T15:44:16Z

#3375 is on the same instance, maybe this is related somehow? But how could this happen? 🤔

ChristophWurst · 2017-02-06T16:06:11Z

Well that other error happens on a POST against /login, so there's probably no authenticated user too.

nickvergessen · 2017-02-07T15:17:10Z

So we ignore this, until the other issue is resolved?

BornToBeRoot · 2017-06-28T07:30:43Z

I see the same issue in the logs on my NC 11.0.3

nickvergessen · 2017-06-28T09:54:58Z

The main question is still: why is this called at all. Guests can not access any of the routes that share this code path.
I can reproduce it with a simple curl: curl -X POST -k https://nextcloud13.local/index.php/apps/files/api/v1/sorting

But after fixing the error with the ITags, it continues with user folder being null, etc. So not sure there is a lot we can do, otherwise we need to fix all DI and make it optional?!

enoch85 · 2017-07-22T21:51:43Z

Shouldn't the milestone be changed? This happens in 12.0.0 as well.

madorian · 2017-10-19T23:25:53Z

I saw this in my log today, in nextcloud 12

Error	PHP	Argument 8 passed to OCA\Files\Controller\ApiController::__construct() must implement interface OCP\Files\Folder, null given, called in /home/vaultlee/public_html/meet.as/apps/files/lib/AppInfo/Application.php on line 52 and defined at /home/vaultlee/public_html/meet.as/apps/files/lib/Controller/ApiController.php#84	2017-10-19T13:48:45+0200
Error	PHP	Argument 4 passed to OCA\Files\Service\TagService::__construct() must implement interface OCP\Files\Folder, null given, called in /home/vaultlee/public_html/meet.as/apps/files/lib/AppInfo/Application.php on line 89 and defined at /home/vaultlee/public_html/meet.as/apps/files/lib/Service/TagService.php#61	2017-10-19T13:48:45+0200
Error	PHP	Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags, null given, called in /home/vaultlee/public_html/meet.as/apps/files/lib/AppInfo/Application.php on line 89 and defined at /home/vaultlee/public_html/meet.as/apps/files/lib/Service/TagService.php#59

MorrisJobke · 2017-10-23T09:52:59Z

@rullzer Is this fixed with #6326?

rullzer · 2017-10-23T11:34:21Z

Nope... anyway let me step trough why this happens...

rullzer · 2017-10-23T11:45:26Z

Ah ok. So it is not that hard to see why actually.

We first try to get the Controller at https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/App.php#L91
And only when we dispatch do we build the refelector etc. https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Http/Dispatcher.php#L86

I feel the 'best' course of action would probably be to run the middleware before we query for the actual controller. However, 'hacking' that in is not trivial.

arnowelzel · 2018-04-12T14:20:33Z

JFTR: This exact error just happened this morning around 6:08 CEST on my Nextcloud 13.0.1 instance six times within two minutes.

phpbg · 2019-08-21T05:48:16Z

Hi,
I just experienced the issue on NC 16.0.3.
Here's the stacktrace:

[index] Error: TypeError: Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags, null given, called in /var/www/nextcloud/apps/files/lib/AppInfo/Application.php on line 97 at <<closure>>

 0. /var/www/nextcloud/apps/files/lib/AppInfo/Application.php line 97
    OCA\Files\Service\TagService->__construct(OC\User\Session {}, OC\Activity\Manager {}, null, null, Symfony\Componen ... {})
 1. /var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php line 118
    OCA\Files\AppInfo\Application->OCA\Files\AppInfo\{closure}("*** sensitive parameters replaced ***")
 2. /var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php line 117
    Pimple\Container->offsetGet("TagService")
 3. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 404
    OC\AppFramework\Utility\SimpleContainer->query("TagService")
 4. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 382
    OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("TagService")
 5. /var/www/nextcloud/apps/files/lib/AppInfo/Application.php line 54
    OC\AppFramework\DependencyInjection\DIContainer->query("TagService")
 6. /var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php line 118
    OCA\Files\AppInfo\Application->OCA\Files\AppInfo\{closure}("*** sensitive parameters replaced ***")
 7. /var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php line 117
    Pimple\Container->offsetGet("APIController")
 8. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 404
    OC\AppFramework\Utility\SimpleContainer->query("APIController")
 9. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 382
    OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("APIController")
10. /var/www/nextcloud/lib/private/AppFramework/App.php line 97
    OC\AppFramework\DependencyInjection\DIContainer->query("APIController")
11. /var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
    OC\AppFramework\App::main("APIController", "getGridView", "*** sensitive parameter replaced ***", {_route: "files.API.getGridView"})
12. <<closure>>
    OC\AppFramework\Routing\RouteActionHandler->__invoke({_route: "files.API.getGridView"})
13. /var/www/nextcloud/lib/private/Route/Router.php line 297
    undefinedundefinedcall_user_func(OC\AppFramework\ ... {}, {_route: "files.API.getGridView"})
14. /var/www/nextcloud/lib/base.php line 975
    OC\Route\Router->match("/apps/files/api/v1/showgridview")
15. /var/www/nextcloud/index.php line 42
    OC::handleRequest()

GET /index.php/apps/files/api/v1/showgridview

royrojer · 2020-05-06T23:52:52Z

I just had the error pop up as well.
Running NC 18.03

[index] Error: TypeError: Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags, null given, called in /var/www/nextcloud/apps/files/lib/AppInfo/Application.php on line 84 at <<closure>>

 0. /var/www/nextcloud/apps/files/lib/AppInfo/Application.php line 84
    OCA\Files\Service\TagService->__construct(OC\User\Session {}, OC\Activity\Manager {}, null, null, OC\EventDispatcher\SymfonyAdapter {})
 1. /var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php line 118
    OCA\Files\AppInfo\Application->OCA\Files\AppInfo\{closure}("*** sensitive parameters replaced ***")
 2. /var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php line 113
    Pimple\Container->offsetGet("TagService")
 3. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 408
    OC\AppFramework\Utility\SimpleContainer->query("TagService")
 4. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 386
    OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("TagService")
 5. /var/www/nextcloud/apps/files/lib/AppInfo/Application.php line 66
    OC\AppFramework\DependencyInjection\DIContainer->query("TagService")
 6. /var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php line 118
    OCA\Files\AppInfo\Application->OCA\Files\AppInfo\{closure}("*** sensitive parameters replaced ***")
 7. /var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php line 113
    Pimple\Container->offsetGet("APIController")
 8. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 408
    OC\AppFramework\Utility\SimpleContainer->query("APIController")
 9. /var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php line 386
    OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("APIController")
10. /var/www/nextcloud/lib/private/AppFramework/App.php line 98
    OC\AppFramework\DependencyInjection\DIContainer->query("APIController")
11. /var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
    OC\AppFramework\App::main("APIController", "getRecentFiles", "*** sensitive parameter replaced ***", {_route: "files.API.getRecentFiles"})
12. <<closure>>
    OC\AppFramework\Routing\RouteActionHandler->__invoke({_route: "files.API.getRecentFiles"})
13. /var/www/nextcloud/lib/private/Route/Router.php line 299
    call_user_func(OC\AppFramework\ ... {}, {_route: "files.API.getRecentFiles"})
14. /var/www/nextcloud/lib/base.php line 1008
    OC\Route\Router->match("/apps/files/api/v1/recent")
15. /var/www/nextcloud/index.php line 38
    OC::handleRequest()

GET /index.php/apps/files/api/v1/recent
from 172.24.xx.xx at 2020-05-06T13:07:32+00:00

AndyXheli · 2021-04-29T19:13:56Z

Issue is till present on NC 21.0.11

{
  "reqId": "7gPw1a3vnE93y7CEmrAm",
  "level": 3,
  "time": "2021-06-08T18:55:46+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "index",
  "method": "GET",
  "url": "/apps/files/api/v1/showgridview",
  "message": {
    "Exception": "TypeError",
    "Message": "Argument 3 passed to OCA\\Files\\Service\\TagService::__construct() must be an instance of OCP\\ITags, null given, called in /var/www/nextcloud/apps/files/lib/AppInfo/Application.php on line 108",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 108,
        "function": "__construct",
        "class": "OCA\\Files\\Service\\TagService",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 155,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 122,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 453,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 431,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 56,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/files/lib/AppInfo/Application.php",
        "line": 88,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 155,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 122,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 453,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 431,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/AppFramework/App.php",
        "line": 130,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/private/Route/Router.php",
        "line": 302,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/var/www/nextcloud/lib/base.php",
        "line": 993,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/index.php",
        "line": 37,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/var/www/nextcloud/apps/files/lib/Service/TagService.php",
    "Line": 61,
    "CustomMessage": "--"
  },
  "userAgent": "Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.109 Safari/537.36",
  "version": "21.0.2.1",
  "id": "60c1521af117a"
}

zkhan93 · 2022-06-15T16:23:42Z

present on 22.2.6.2 as well

{
  "reqId": "JD7HBJ7SwxrlXktXm4b2",
  "level": 3,
  "time": "2022-06-15T16:16:00+00:00",
  "user": "--",
  "app": "index",
  "method": "GET",
  "url": "/apps/files/api/v1/recent",
  "message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /var/www/html/apps/files/lib/AppInfo/Application.php on line 106",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36",
  "version": "22.2.6.2",
  "exception": {
    "Exception": "TypeError",
    "Message": "OCA\\Files\\Service\\TagService::__construct(): Argument #3 ($tagger) must be of type OCP\\ITags, null given, called in /var/www/html/apps/files/lib/AppInfo/Application.php on line 106",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/html/apps/files/lib/AppInfo/Application.php",
        "line": 106,
        "function": "__construct",
        "class": "OCA\\Files\\Service\\TagService",
        "type": "->",
        "args": [
          { "__class__": "OC\\User\\Session" },
          { "__class__": "OC\\Activity\\Manager" },
          null,
          null,
          { "__class__": "OC\\EventDispatcher\\SymfonyAdapter" }
        ]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 160,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": ["*** sensitive parameters replaced ***"]
      },
      {
        "file": "/var/www/html/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": ["*** sensitive parameters replaced ***"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 127,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": ["OCA\\Files\\Service\\TagService"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 454,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": ["OCA\\Files\\Service\\TagService"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 432,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": ["OCA\\Files\\Service\\TagService"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 56,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": ["OCA\\Files\\Service\\TagService"]
      },
      {
        "file": "/var/www/html/apps/files/lib/AppInfo/Application.php",
        "line": 86,
        "function": "get",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": ["OCA\\Files\\Service\\TagService"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 160,
        "function": "OCA\\Files\\AppInfo\\{closure}",
        "class": "OCA\\Files\\AppInfo\\Application",
        "type": "->",
        "args": ["*** sensitive parameters replaced ***"]
      },
      {
        "file": "/var/www/html/3rdparty/pimple/pimple/src/Pimple/Container.php",
        "line": 118,
        "function": "OC\\AppFramework\\Utility\\{closure}",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": ["*** sensitive parameters replaced ***"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php",
        "line": 127,
        "function": "offsetGet",
        "class": "Pimple\\Container",
        "type": "->",
        "args": ["APIController"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 454,
        "function": "query",
        "class": "OC\\AppFramework\\Utility\\SimpleContainer",
        "type": "->",
        "args": ["APIController"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php",
        "line": 432,
        "function": "queryNoFallback",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": ["APIController"]
      },
      {
        "file": "/var/www/html/lib/private/AppFramework/App.php",
        "line": 129,
        "function": "query",
        "class": "OC\\AppFramework\\DependencyInjection\\DIContainer",
        "type": "->",
        "args": ["APIController"]
      },
      {
        "file": "/var/www/html/lib/private/Route/Router.php",
        "line": 302,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "APIController",
          "getRecentFiles",
          "*** sensitive parameter replaced ***",
          { "_route": "files.API.getRecentFiles" }
        ]
      },
      {
        "file": "/var/www/html/lib/base.php",
        "line": 1006,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": ["/apps/files/api/v1/recent"]
      },
      {
        "file": "/var/www/html/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::",
        "args": []
      }
    ],
    "File": "/var/www/html/apps/files/lib/Service/TagService.php",
    "Line": 59,
    "CustomMessage": "--"
  }
}

nickvergessen · 2022-06-29T09:25:50Z

This happens when a request is being sent but the session expired in the meantime or when a guest sends a request to a controller that has no method accessible for guests.

Also becomes clearly visible in your log entry. "user": "--", but guests don't have files listing so "url": "/apps/files/api/v1/recent", is not a valid location.

Therefor while annoying as it creates an error in the log, it actually has no negative impact for any real user and can therefor be ignored.

szaimen · 2022-11-26T14:23:08Z

Hi, please update to at least 23.0.12 and report back if it fixes the issue. Thank you!

nickvergessen · 2022-11-26T14:28:52Z

As per above this is still happening. Seeing it at least once a week on our 25 instance

hakunamatata97k · 2022-11-27T23:17:43Z

Sadly, the issue persists on my Nextcloud Hub 3 25.0.1 as well.

nickvergessen · 2022-12-08T09:17:46Z

As sad as you are about it, it does not mean anything is broken or not working. It's a guest loading a controller that does not allow guests to do anything. So while the log entry is annoying, nothing impacts the user in the real world

thenamelessthing · 2022-12-18T03:46:28Z

just updated to NC25.0.2 and I got this problem! Any workaround?

nickvergessen · 2022-12-18T03:58:20Z

See comment above your's

LukasReschke added the bug label Feb 4, 2017

LukasReschke added this to the Nextcloud 11.0.2 milestone Feb 4, 2017

nickvergessen self-assigned this Feb 5, 2017

MorrisJobke modified the milestones: Nextcloud 11.0.2, Nextcloud 11.0.3 Feb 27, 2017

nickvergessen removed their assignment Mar 6, 2017

MorrisJobke modified the milestones: Nextcloud 11.0.3, Nextcloud 11.0.4 Apr 24, 2017

nickvergessen removed this from the Nextcloud 11.0.4 milestone Jul 22, 2017

nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018

nextcloud-bot mentioned this issue Aug 9, 2018

TypeError: Argument 8 passed to OCA\Files_Sharing\Controller\ShareAPIController::__construct() must be of th... #10601

Closed

nextcloud-bot mentioned this issue Nov 12, 2018

Can't download large folders (~>1GB) - Error "Argument 2 passed to OC\Streamer::__construct() must be of the type integer, float given..." #12422

Closed

skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019

ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019

skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 10, 2020

solracsf mentioned this issue Apr 29, 2021

TypeError: Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags, null given, called in /var/www/nextcloud/apps/files/lib/AppInfo/Application.php on line 108 #26816

Closed

solracsf changed the title ~~Argument 3 passed to OCA\\\\Files\\\\Service\\\\TagService::__construct() must be an instance of OCP\\\\ITags~~ Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags Aug 9, 2021

szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Nov 26, 2022

nickvergessen added 1. to develop Accepted and waiting to be taken care of and removed needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 26, 2022

szaimen added the 25-feedback label Nov 26, 2022

solracsf mentioned this issue Mar 6, 2023

fix(files): Fix controller setup for guests #36904

Merged

4 tasks

nickvergessen closed this as completed Mar 6, 2023

nextcloud locked as too heated and limited conversation to collaborators Apr 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Argument 3 passed to `OCA\Files\Service\TagService::__construct()` must be an instance of `OCP\ITags` #3376

Argument 3 passed to `OCA\Files\Service\TagService::__construct()` must be an instance of `OCP\ITags` #3376

LukasReschke commented Feb 4, 2017 •

edited by solracsf

Loading

LukasReschke commented Feb 4, 2017

ChristophWurst commented Feb 6, 2017

LukasReschke commented Feb 6, 2017 •

edited

Loading

ChristophWurst commented Feb 6, 2017

nickvergessen commented Feb 7, 2017

BornToBeRoot commented Jun 28, 2017

nickvergessen commented Jun 28, 2017

enoch85 commented Jul 22, 2017

madorian commented Oct 19, 2017 •

edited by solracsf

Loading

MorrisJobke commented Oct 23, 2017

rullzer commented Oct 23, 2017

rullzer commented Oct 23, 2017

arnowelzel commented Apr 12, 2018

phpbg commented Aug 21, 2019

royrojer commented May 6, 2020 •

edited by solracsf

Loading

AndyXheli commented Apr 29, 2021 •

edited by solracsf

Loading

zkhan93 commented Jun 15, 2022 •

edited

Loading

nickvergessen commented Jun 29, 2022

szaimen commented Nov 26, 2022

nickvergessen commented Nov 26, 2022

hakunamatata97k commented Nov 27, 2022

nickvergessen commented Dec 8, 2022

thenamelessthing commented Dec 18, 2022

nickvergessen commented Dec 18, 2022

Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags #3376

Argument 3 passed to OCA\Files\Service\TagService::__construct() must be an instance of OCP\ITags #3376

Comments

LukasReschke commented Feb 4, 2017 • edited by solracsf Loading

LukasReschke commented Feb 4, 2017

ChristophWurst commented Feb 6, 2017

LukasReschke commented Feb 6, 2017 • edited Loading

ChristophWurst commented Feb 6, 2017

nickvergessen commented Feb 7, 2017

BornToBeRoot commented Jun 28, 2017

nickvergessen commented Jun 28, 2017

enoch85 commented Jul 22, 2017

madorian commented Oct 19, 2017 • edited by solracsf Loading

MorrisJobke commented Oct 23, 2017

rullzer commented Oct 23, 2017

rullzer commented Oct 23, 2017

arnowelzel commented Apr 12, 2018

phpbg commented Aug 21, 2019

royrojer commented May 6, 2020 • edited by solracsf Loading

AndyXheli commented Apr 29, 2021 • edited by solracsf Loading

zkhan93 commented Jun 15, 2022 • edited Loading

nickvergessen commented Jun 29, 2022

szaimen commented Nov 26, 2022

nickvergessen commented Nov 26, 2022

hakunamatata97k commented Nov 27, 2022

nickvergessen commented Dec 8, 2022

thenamelessthing commented Dec 18, 2022

nickvergessen commented Dec 18, 2022

Argument 3 passed to `OCA\Files\Service\TagService::__construct()` must be an instance of `OCP\ITags` #3376

Argument 3 passed to `OCA\Files\Service\TagService::__construct()` must be an instance of `OCP\ITags` #3376

LukasReschke commented Feb 4, 2017 •

edited by solracsf

Loading

LukasReschke commented Feb 6, 2017 •

edited

Loading

madorian commented Oct 19, 2017 •

edited by solracsf

Loading

royrojer commented May 6, 2020 •

edited by solracsf

Loading

AndyXheli commented Apr 29, 2021 •

edited by solracsf

Loading

zkhan93 commented Jun 15, 2022 •

edited

Loading