Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] Focused item overlaps neighbor elements with text and border #35201

Closed
Tracked by #33741
JuliaKirschenheuter opened this issue Nov 16, 2022 · 7 comments · Fixed by #35501 or #35545
Closed
Tracked by #33741

[BITV] Focused item overlaps neighbor elements with text and border #35201

JuliaKirschenheuter opened this issue Nov 16, 2022 · 7 comments · Fixed by #35501 or #35545

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 16, 2022

  • Keyboard focus overlaps with text

@jancborchardt you mean

Screenshot from 2022-11-15 11-27-55 ?

Then i guess we need another design

@JuliaKirschenheuter
Copy link
Contributor Author

Answer from @jancborchardt:

@JuliaKirschenheuter Only using border-bottom instead of all around seems fine in this case then?

@JuliaKirschenheuter
Copy link
Contributor Author

I've spent some time with experimenting around another focus state (also with using border-bottom instead of whole border).

My conclusion:

  1. Other border type or whatever would not solve initial problem because focus overlaps neighbor elements via zooming. In this case we have to re-think design behavior. Even without any border:
    image

  2. If i place a border-bottom under a text, there are much other places to fix and this is still not a solution for this issue and isn't beautiful too. Places to fix: zooming via focus, text position, probably icon position.
    Peek 2022-11-16 12-15

  3. If i place a border-bottom under a link element than this is still not a solution for this issue and isn't beautiful too.
    Peek 2022-11-16 12-09

@jancborchardt i have no quick-fix for now. Could you please discuss with other designers about possible solution? I guess we have to change design / behavior.

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 16, 2022
@JuliaKirschenheuter
Copy link
Contributor Author

@PVince81, @Pytal what are you thinking about it?

@JuliaKirschenheuter JuliaKirschenheuter changed the title Keyboard focus overlaps with text Focused item overlaps neighbor elements with text and border Nov 16, 2022
@jancborchardt
Copy link
Member

I also played around with it a bit and we did some tries at improving it in the past, including with background-color (which never looks good).

I think by now the easiest and non overlapping would be if we

  • Simply do not expand the text anymore and just use title? The full text is in the element so it is accessible like that.
  • We put in the guidelines that app names should be short. Apple does it similarly, cause there is just a limit to it
  • We could (via JS) reduce the tracking of the font if the text is too long to save some space. This is also what apple does
  • We could also increase the width of the elements a little bit

As for the focus highlight, instead of border-bottom we could use ::before, like we do for the currently active app. That also looks nicer since it does not move the rest of the content and we can give it rounded corners:
image

What do you think @JuliaKirschenheuter?

@jancborchardt
Copy link
Member

Ah and just to be clear - if it is only about the focus border overlapping the text, then it is rather easy, literally just using the ::before style instead of the border around it.

@JuliaKirschenheuter
Copy link
Contributor Author

Thanks for your ideas @jancborchardt! Some of your point are't clear to me, could you please extend your ideas a bit?

Simply do not expand the text anymore and just use title? The full text is in the element so it is accessible like that.

What do you mean exactly? You mean take away the names of the app like "Files", "Photos", "Contacts" and so on?

We put in the guidelines that app names should be short.

Please give me an example how should i look like.

We could (via JS) reduce the tracking of the font if the text is too long to save some space.

What do you mean with "reduce the tracking of the font"? It is cut per default and the whole name will be shown per focus.

We could also increase the width of the elements a little bit.

We cant't control the width of all languages. In actual design we have strong fixed width, of coarse we can expand it but we still can't control everything.

As for the focus highlight, instead of border-bottom we could use ::before, like we do for the currently active app.

Well, sure.

⚠️ But the main thing is: how should we handle overlapped text, because this is the most important thing.

image

@jancborchardt
Copy link
Member

Let me try to reformulate:

[…] we choose app names which are […] short and easily fit in the top navigation without being cut off.

@PVince81 PVince81 changed the title Focused item overlaps neighbor elements with text and border [BITV] Focused item overlaps neighbor elements with text and border Nov 17, 2022
@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment