New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styles for #33741. Remove boards and add underlines. #35545
Add styles for #33741. Remove boards and add underlines. #35545
Conversation
/backport to stable25 |
|
/compile / |
@JuliaKirschenheuter looking at what the compile bot did did you forget to apply your changes to server.scss? |
I think i haven't forgotten, but in some point after local rebasing i've lost them. I will check it carefully in a future. |
You have to make your changes on the source .scss files. The .css is the output. See the https://github.com/nextcloud/server/blob/master/core/css/server.scss for the included styles. One of those includes will have the rules you adjusted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking:
You have to make your changes on the source .scss files. The .css is the output.
3b98142
to
434f4ac
Compare
@JuliaKirschenheuter can you try to add your logic into the block above? It looks like this is now dublicating a lot of the logic... |
434f4ac
to
35a75ed
Compare
35a75ed
to
e4cb7b6
Compare
e4cb7b6
to
a7d8763
Compare
/compile amend / |
a7d8763
to
b726717
Compare
b726717
to
9d0e613
Compare
/compile amend / |
78a7480
to
e021061
Compare
e021061
to
7034602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks 👍
…) have no overlapping. Add native tooltips to items. Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
7034602
to
4432069
Compare
Summary
TODO
Checklist