Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.4.1/7.1 - The selected/active navigation item "Logging" in the left-side navigation has a contrast difference of less than 3:1 with the color of adjacent navigation items. (1) #36947

Closed
1 task
AndyScherzinger opened this issue Mar 1, 2023 · 4 comments · Fixed by nextcloud-libraries/nextcloud-vue#4155, #38459 or #38460
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility design Design, UI, UX, etc.

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 1, 2023

Additional emphasis such as bolding or underlining is also missing.

  • Fix

fe580438a652a6f47479931eb8768873

414c728086658dfdb595a873bd04deeb

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-45ae33ca9f-v7-n1

@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility design Design, UI, UX, etc. labels Mar 1, 2023
@AndyScherzinger AndyScherzinger changed the title [BITV] 9.1.4.1/7.1 - The selected/active navigation item "Logging" in the left-side navigation has a contrast difference of less than 3:1 with the color of adjacent navigation items. Additional emphasis such as bolding or underlining is also missing. (1) [BITV] 9.1.4.1/7.1 - The selected/active navigation item "Logging" in the left-side navigation has a contrast difference of less than 3:1 with the color of adjacent navigation items. (1) Apr 21, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this May 9, 2023
@JuliaKirschenheuter
Copy link
Contributor

Dear @michaelnissenbaum,

I've discussed possible implementations with our designers. After several reflections we came to conclusion that the best way would be to add a border with color --color-primary-element like:

Screenshot from 2023-05-15 12-58-06
Screenshot from 2023-05-15 12-57-48

It that would be be ok, should we take 1px or 2px as border width?

Another alternative would be to change background color, but designers saying they don't use such a dark color anywhere other than the primary button and on the borders.

Would a solution with border work? Thank you!

@michaelnissenbaum
Copy link

Hi @JuliaKirschenheuter . Using a border to highlight an active menu element is a good idea. I would lean towards a 2px border. However, it's important to ensure that the border has a minimum contrast ratio of 3:1 with the background. In the screenshot, we have contrasts below 3:1.

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented May 15, 2023

Thank you @michaelnissenbaum ,

I've spoken with designers again and there is final version:

Make text bolder and border around selected/active navigation item.
Screenshot from 2023-05-16 08-57-39

Could you please give us your opinion? Thanks a lot!

@michaelnissenbaum
Copy link

@JuliaKirschenheuter The solution looks good from my perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility design Design, UI, UX, etc.
Projects
Archived in project
3 participants