Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.3.3.1/8.1 - Modale dialog "Authentication required" - If the "Password" input field is left empty, an error message appears. This error message "Failed to authenticate, please try again" is unspecific and does not give any information about which input caused the error. (1) #37080

Closed
AndyScherzinger opened this issue Mar 7, 2023 · 7 comments · Fixed by nextcloud-libraries/nextcloud-password-confirmation#605
Assignees
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 7, 2023

Active users - Users - Nextcloud
https://try.nextcloud.com/ltd/a11y/index.php/settings/users

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-c3b56e67ab-v8-n1

@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility labels Mar 7, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Aug 21, 2023
@JuliaKirschenheuter
Copy link
Contributor

@michaelnissenbaum could you please check it if this issue is already resolved?

In my opinion it is but i want to be sure. Thanks a lot!

Peek 2023-08-24 09-44

@JuliaKirschenheuter
Copy link
Contributor

#38839

@michaelnissenbaum
Copy link

michaelnissenbaum commented Aug 24, 2023

Hi @JuliaKirschenheuter. No, from my perspective, the issue still remains. This concerns the modal dialog with the error message "Failed to authenticate, please try again." The error message is unspecific and unclear in this case.
CleanShot 2023-08-24 at 20 41 33@2x

Additionally I found another issue. The button with the eye icon doesn't have alternative text - an empty "aria-label" attribute is used.

CleanShot 2023-08-24 at 20 45 46@2x

And the button with the arrow has an incorrect alternative text - aria-label="Clear text".
CleanShot 2023-08-24 at 20 46 41@2x

@JuliaKirschenheuter
Copy link
Contributor

Thank you @michaelnissenbaum!

@JuliaKirschenheuter
Copy link
Contributor

@artonge am i right that we would need much more backend differentiation for showing a detailed information?
Or could i probably just change this message:

Screenshot from 2023-09-26 16-35-58

to "your password was wrong. please try again"? Seems to be that we have only this one case.

@artonge
Copy link
Contributor

artonge commented Sep 27, 2023

I am not sure how this is an accessibility issue. There is only one field, so what's wrong is obvious in this case. No ?

In any case, we could do two things:

  1. Prevent the submission of the form if the input is empty.
  2. Clearly state that the password is wrong. No need for backend differentiation here, as only the password comes into play, so we know for sure that it is the password that is wrong. The current message comes from:
    config.error = t('core', 'Failed to authenticate, try again')
    OC.PasswordConfirmation.requirePasswordConfirmation(self.callback, config)

@ShGKme
Copy link
Contributor

ShGKme commented Oct 10, 2023

Requires nextcloud/password-confirmation update

@ShGKme ShGKme reopened this Oct 10, 2023
@ShGKme ShGKme closed this as completed Oct 17, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants