Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct aria-label on action input and text field #40662

Merged

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Sep 27, 2023

Summary

Before:
And the button with the arrow has an incorrect alternative text - aria-label="Clear text".
CleanShot 2023-08-24 at 20 46 41@2x

After:
Screenshot from 2023-09-27 17-28-51

Checklist

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix-37080_correct_aria_label_text_on_action_inputs branch from d09a946 to c8fef9a Compare September 28, 2023 14:00
apps/settings/src/components/GroupListItem.vue Outdated Show resolved Hide resolved
apps/settings/src/components/Users/UserRow.vue Outdated Show resolved Hide resolved
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix-37080_correct_aria_label_text_on_action_inputs branch from 5f9b81b to 7561056 Compare October 4, 2023 10:05
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix-37080_correct_aria_label_text_on_action_inputs branch from 7561056 to 1431b0d Compare October 4, 2023 12:29
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix-37080_correct_aria_label_text_on_action_inputs branch from f8ba766 to e1bda0a Compare October 4, 2023 15:29
@JuliaKirschenheuter JuliaKirschenheuter merged commit 7641af5 into master Oct 4, 2023
42 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix-37080_correct_aria_label_text_on_action_inputs branch October 4, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants