Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.4.1.2/8.5 - The "Settings" button is an accordion button that should be implemented as such with the aria-expanded attribute. #37136

Closed
2 tasks
AndyScherzinger opened this issue Mar 8, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vue#4109
Closed
2 tasks

[BITV] 9.4.1.2/8.5 - The "Settings" button is an accordion button that should be implemented as such with the aria-expanded attribute. #37136

AndyScherzinger opened this issue Mar 8, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vue#4109
Assignees
@Fenn-CS
Labels
1. to develop Accepted and waiting to be taken care of accessibility

Comments

@AndyScherzinger
Copy link
Member

See https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ for further details. (1)

  • Fix
  • Backport

4b98244143224a248f230b7ff75c24c8

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-bfbf07e5c3-v8-n5
@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility labels Mar 8, 2023
@Fenn-CS Fenn-CS self-assigned this May 10, 2023
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 13, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
223d38d 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS mentioned this issue May 13, 2023
Merged
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 13, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
b9829ab 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 17, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
1ca5722 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 17, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
484635d 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 17, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
06be3b9 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 17, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
b31fc57 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit to nextcloud-libraries/nextcloud-vue that referenced this issue May 17, 2023
@Fenn-CS
Add aria-expanded to settings accordion button
12ee9d4 
Mark settings button that triggers the expand/collaps of the
side nav settings with aria-expanded attribute to improve accesibility.

Resolves : nextcloud/server#37136

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fenn-CS Fenn-CS

Labels
1. to develop Accepted and waiting to be taken care of accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aria-expanded to settings accordion button nextcloud-libraries/nextcloud-vue
2 participants
@AndyScherzinger @Fenn-CS