-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Front-end build touches *all* apps scss/css #38092
Comments
Idea: read https://github.com/nextcloud/server/blob/master/core/shipped.json and only run the sass compiler for apps in there. Added benefit: the local build with additional apps becomes faster. |
Suggestion of @ChristophWurst would be fine with me, so looking for the feedback of @skjnldsv and depending on the efforts and availability I'd be okay with adding this for 27 during the stabilization phase. Not sure what you think @skjnldsv |
Sure :) |
The cs fixer is able to ignore anything ignored by git: Line 12 in 263a691
But yes, lint probably has the same issue. Albeit it doesn't modify additional apps. |
So how much work do we expect this to be and who could take care of it? |
2h for an experienced frontender |
Bug description
Running
npm run build
touches app scss and creates unexpected css filesI raised this earlier in #35622 (comment) already and a discussion spawned at nextcloud/standards#9 but until a decision has been made and docs still recommend people to clone into
apps
I think it's fair to say the server front-end should leave unrelated apps untouched.Steps to reproduce
Expected behavior
No changes in the calendar repo
Installation method
None
Nextcloud Server version
master
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
cc @skjnldsv @AndyScherzinger
The text was updated successfully, but these errors were encountered: