Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Do not sass-compile external apps #38590

Merged
merged 1 commit into from Jun 6, 2023
Merged

chore: Do not sass-compile external apps #38590

merged 1 commit into from Jun 6, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jun 1, 2023 •
edited

Summary

Only compile apps in this repo. Ignore ignored directories.

Discovered while rebuilding PRs that don't build on CI. I had to reset all external apps' css/ directory because of stray sass compilation.

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Jun 1, 2023
@ChristophWurst ChristophWurst self-assigned this Jun 1, 2023
@ChristophWurst

This comment was marked as outdated.

Sign in to view
@ChristophWurst ChristophWurst marked this pull request as draft June 1, 2023 17:12
@ChristophWurst
chore: Do not sass-compile external apps
1ea2082 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst marked this pull request as ready for review June 1, 2023 17:43
@ChristophWurst
Copy link
Member Author

so

Antreesy
Antreesy approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me locally: compiler ignore all the apps/directory, which are not included in .gitignore.

But Psalm static code analysis is still red, so it's up to you to decide

@ChristophWurst
Copy link
Member Author

Psalm fails because of the hosted GitHub runners. The failure is caused by the system, not my changes.

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 6, 2023
@ChristophWurst ChristophWurst merged commit f96afcf into master Jun 6, 2023
36 of 37 checks passed
@ChristophWurst ChristophWurst deleted the chore/sass-no-external-apps branch June 6, 2023 12:56
@ChristophWurst ChristophWurst mentioned this pull request Oct 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@Antreesy Antreesy Antreesy approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: Front-end build touches *all* apps scss/css
3 participants
@ChristophWurst @marcelklehr @Antreesy