[Bug]: When running repair steps for the first time, changed classes get not loaded properly #38158

dartcafe · 2023-05-09T19:54:07Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
Nextcloud Server is running on 64bit capable CPU, PHP and OS.
I agree to follow Nextcloud's Code of Conduct.

Bug description

When updating an app (here it is Polls) via occ it seems that altered classes, which are used inside a repair step get not updated properly (caching??). A second update run then installs the app with out an exception.

Steps to reproduce

See details here: nextcloud/polls#2900 and nextcloud/polls#2793

Expected behavior

changed classes should be loaded properly while updating an app.

Installation method

Community Web installer on a VPS or web space

Nextcloud Server version

26

Operating system

None

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "test.yagst.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "tempdirectory": "\/tmp\/nextcloud",
        "dbtype": "mysql",
        "version": "26.0.1.1",
        "overwrite.cli.url": "http:\/\/xxx",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "theme": "",
        "loglevel": 0,
        "maintenance": false,
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "app_install_overwrite": [
            "polls"
        ]
    }
}

List of activated Apps

Enabled:
  - activity: 2.18.0
  - admin_audit: 1.16.0
  - bruteforcesettings: 2.6.0
  - circles: 26.0.0
  - cloud_federation_api: 1.9.0
  - comments: 1.16.0
  - contactsinteraction: 1.7.0
  - dashboard: 7.6.0
  - dav: 1.25.0
  - federatedfilesharing: 1.16.0
  - federation: 1.16.0
  - files: 1.21.1
  - files_external: 1.18.0
  - files_pdfviewer: 2.7.0
  - files_rightclick: 1.5.0
  - files_sharing: 1.18.0
  - files_trashbin: 1.16.0
  - files_versions: 1.19.1
  - firstrunwizard: 2.15.0
  - logreader: 2.11.0
  - lookup_server_connector: 1.14.0
  - nextcloud_announcements: 1.15.0
  - notifications: 2.14.0
  - oauth2: 1.14.0
  - password_policy: 1.16.0
  - photos: 2.2.0
  - polls: 5.0.5
  - privacy: 1.10.0
  - provisioning_api: 1.16.0
  - recommendations: 1.5.0
  - related_resources: 1.1.0-alpha1
  - serverinfo: 1.16.0
  - settings: 1.8.0
  - sharebymail: 1.16.0
  - support: 1.9.0
  - survey_client: 1.14.0
  - systemtags: 1.16.0
  - text: 3.7.2
  - theming: 2.1.1
  - twofactor_backupcodes: 1.15.0
  - updatenotification: 1.16.0
  - user_ldap: 1.16.0
  - user_status: 1.6.0
  - viewer: 1.10.0
  - weather_status: 1.6.0
  - workflowengine: 2.8.0
Disabled:
  - encryption: 2.14.0 (installed 2.8.1)
  - suspicious_login: 4.4.0
  - twofactor_totp: 8.0.0-alpha.0

Nextcloud Signing status

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- core
	- INVALID_HASH
		- .user.ini

Raw output
==========
Array
(
    [core] => Array
        (
            [INVALID_HASH] => Array
                (
                    [.user.ini] => Array
                        (
                            [expected] => 4843b3217e91f8536cb9b52700efb20300290292cf6286f92794d4cec99df286afeb7dd6c91b1be20bc55eda541eef230a5c5e7dcd46c189edd0ed1e80c6d3f5
                            [current] => 3fecf59adb63f3529c30449b25264e1fd2a447b855afae05821110b50039a5e51f6c4f3349399512602b5544a65cdf6fa3c50b81f16fcbe2e0be175d9f6c4c82
                        )

                )

        )

)

Nextcloud Logs

sudo -u www-data php8.1 ./occ app:update --all
polls new version available: 5.0.5
An unhandled exception has been thrown:
Error: Call to undefined method OCA\Polls\Db\TableManager::deleteAllDuplicates() in /var/www/nc_01/nextcloud/apps/polls/lib/Migration/RepairSteps/DeleteInvalidRecords.php:70
Stack trace:
#0 /var/www/nc_01/nextcloud/lib/private/Repair.php(127): OCA\Polls\Migration\RepairSteps\DeleteInvalidRecords->run()
#1 /var/www/nc_01/nextcloud/lib/private/legacy/OC_App.php(1068): OC\Repair->run()
#2 /var/www/nc_01/nextcloud/lib/private/legacy/OC_App.php(1005): OC_App::executeRepairSteps()
#3 /var/www/nc_01/nextcloud/lib/private/Installer.php(200): OC_App::updateApp()
#4 /var/www/nc_01/nextcloud/core/Command/App/Update.php(107): OC\Installer->updateAppstoreApp()
#5 /var/www/nc_01/nextcloud/apps/recognize/vendor/symfony/console/Command/Command.php(298): OC\Core\Command\App\Update->execute()
#6 /var/www/nc_01/nextcloud/apps/recognize/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
#7 /var/www/nc_01/nextcloud/apps/recognize/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#8 /var/www/nc_01/nextcloud/apps/recognize/vendor/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun()
#9 /var/www/nc_01/nextcloud/lib/private/Console/Application.php(214): Symfony\Component\Console\Application->run()
#10 /var/www/nc_01/nextcloud/console.php(100): OC\Console\Application->run()
#11 /var/www/nc_01/nextcloud/occ(11): require_once('...')
#12 {main}

Additional info

The method OCA\Polls\Db\TableManager::deleteAllDuplicates() was added in the last Polls version (5.0.5).

The error trace is taken from nextcloud/polls#2900
The system configuration is taken from my test instance, where I could observe this problem too.

szaimen · 2023-05-11T08:47:16Z

cc @nextcloud/server-backend

ChristophWurst · 2023-05-11T12:25:52Z

Same with nextcloud/mail#8146 and nextcloud/calendar#5191

Summary: the app migration/repair step are run with a mix of old app code and new app code.

I think the only possible fix is to run migrations and repair steps in a new process

ChristophWurst · 2023-05-11T12:26:17Z

https://github.com/search?q=repo%3Anextcloud%2Fmail+method_exists+path%3A%2F%5Elib%5C%2FMigration%5C%2F%2F&type=code for all the previous monkey patches

szaimen · 2023-06-08T17:00:03Z

nextcloud/documentation#10578

ChristophWurst · 2023-06-29T16:59:51Z

Let's keep separate issues separate

In-process replacement of code during an app update (this ticket)
Lack of opcache refresh after changed code: [Bug]: OPCache doesn't refresh when code changes #39079

These require two distinct fixes.

szaimen · 2023-09-10T11:03:01Z

Possibky this was fixed with #40349

dartcafe · 2023-09-10T15:43:31Z

Will check it with 28 beta

ChristophWurst · 2023-09-11T04:33:23Z

#38158 (comment)

dartcafe · 2023-11-03T05:53:24Z

I tried to reproduce this error in 27.1.3 before updating to 28-beta1, but the migration runs thru with new methods. So it seems it is already fixed in 27.

In 28-beta1 the problem does not occur as well.

ChristophWurst · 2023-11-03T09:46:33Z

I do not think this is fixed. See #38158 (comment) for the distinction of the two problems with caching code. One was fixed, the other wasn't.

dartcafe · 2023-11-03T20:00:05Z

Funny thing. If it is still present, then I did something weird while trying to reproduce it. I was sure, I provocated the issue by adding and calling new methods to the repais steps. I will try my luck again.

Reopen?

ChristophWurst · 2023-11-06T08:57:51Z

calling new methods to the repais steps

It works if the class hasn't been loaded prior to code replacement.

Works:

Nextcloud boots
Nextcloud replaces app code
Nextcloud runs upgrade routine
Upgrade routine loads app class

Doesn't work

Nextcloud boots and loads an app class
Nextcloud replaces app code
Nextcloud runs upgrade routine
Upgrade routine calls new method on the old version of the class

dartcafe added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 9, 2023

szaimen added the 26-feedback label May 9, 2023

szaimen added 1. to develop Accepted and waiting to be taken care of high technical debt and removed bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback labels May 11, 2023

This was referenced May 11, 2023

[5.0.5] Error when updating - Call to undefined method OCA\Polls\Db\TableManager::deleteAllDuplicates() nextcloud/polls#2900

Closed

Update to 4.1.7 fails and leaves NC in maintenance mode nextcloud/polls#2793

Closed

juliushaertl mentioned this issue May 30, 2023

4.4.0-alpha.2: Migration step 'OCA\Calendar\Migration\Version4004Date20230414163505' is unknown nextcloud/calendar#5191

Closed

dartcafe mentioned this issue Jun 3, 2023

Upgrading From 26 to 27rc3 [Bug]: Repair Error nextcloud/polls#2934

Closed

9 tasks

juliushaertl mentioned this issue Jun 14, 2023

[Bug]: QueryNotFoundException in app after changing file structure for Nextcloud 27 #38797

Closed

8 tasks

dartcafe mentioned this issue Jun 29, 2023

Error after update to 5.1.0: "BadFunctionCallException: lastInteraction is not a valid attribute" nextcloud/polls#2963

Closed

18 tasks

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

dartcafe mentioned this issue Aug 15, 2023

Polls 5.3.0-beta1 released (14-08-2023) nextcloud/polls#3025

Closed

joshtrichards added feature: occ feature: apps management labels Aug 25, 2023

dartcafe mentioned this issue Sep 7, 2023

Error while updating [Call to undefined method ...] nextcloud/polls#3057

Closed

dartcafe closed this as completed Nov 3, 2023

ChristophWurst reopened this Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: When running repair steps for the first time, changed classes get not loaded properly #38158

[Bug]: When running repair steps for the first time, changed classes get not loaded properly #38158

dartcafe commented May 9, 2023 •

edited

szaimen commented May 11, 2023

ChristophWurst commented May 11, 2023

ChristophWurst commented May 11, 2023

szaimen commented Jun 8, 2023

This comment was marked as off-topic.

ChristophWurst commented Jun 29, 2023 •

edited

This comment was marked as outdated.

szaimen commented Sep 10, 2023

dartcafe commented Sep 10, 2023

ChristophWurst commented Sep 11, 2023

dartcafe commented Nov 3, 2023

ChristophWurst commented Nov 3, 2023 •

edited

dartcafe commented Nov 3, 2023

ChristophWurst commented Nov 6, 2023

[Bug]: When running repair steps for the first time, changed classes get not loaded properly #38158

[Bug]: When running repair steps for the first time, changed classes get not loaded properly #38158

Comments

dartcafe commented May 9, 2023 • edited

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Nextcloud Server version

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

szaimen commented May 11, 2023

ChristophWurst commented May 11, 2023

ChristophWurst commented May 11, 2023

szaimen commented Jun 8, 2023

This comment was marked as off-topic.

ChristophWurst commented Jun 29, 2023 • edited

This comment was marked as outdated.

szaimen commented Sep 10, 2023

dartcafe commented Sep 10, 2023

ChristophWurst commented Sep 11, 2023

dartcafe commented Nov 3, 2023

ChristophWurst commented Nov 3, 2023 • edited

dartcafe commented Nov 3, 2023

ChristophWurst commented Nov 6, 2023

dartcafe commented May 9, 2023 •

edited

ChristophWurst commented Jun 29, 2023 •

edited

ChristophWurst commented Nov 3, 2023 •

edited