Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery.globalEval()={} - Problem with password strength and files_markdown #4067

Closed
michaelletzgus opened this issue Mar 26, 2017 · 3 comments · Fixed by #4083
Closed

jQuery.globalEval()={} - Problem with password strength and files_markdown #4067

michaelletzgus opened this issue Mar 26, 2017 · 3 comments · Fixed by #4083
Assignees
@LukasReschke
Labels
bug
Milestone
Nextcloud 12.0

Comments

@michaelletzgus
Copy link
Contributor

michaelletzgus commented Mar 26, 2017 •
edited

Current master, personal settings, type a password into the "new password field"

Expected: Show password strength

Actual:
ReferenceError: zxcvbn is not defined in jquery.strengthify.js

Reason:
The script loading and executing of /core/vendor/zxcvbn/dist/zxcvbn.js at the bottom of /core/vendor/strengthify/jquery.strengthify.js is rendered dysfunctional by 148e7ab due to

$.ajaxSetup({
		contents: {
			script: false
		}
	});
jQuery.globalEval = function(){};

in core/js/js.js which is needed by jQuery ajax()/getScript() to execute loaded script.

148e7ab also brakes files_markdown (see #3696 (comment))
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Mar 26, 2017
@LukasReschke LukasReschke self-assigned this Mar 26, 2017
LukasReschke added a commit to LukasReschke/strengthify that referenced this issue Mar 26, 2017
@LukasReschke
Use eval directly
ab2a74a 
We've overwritten jQuery.globalEval() for security reasons in Nextcloud, to make this now compatible again I've changed this code to manually call eval.

Ref nextcloud/server#4067

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke mentioned this issue Mar 26, 2017
Merged
@LukasReschke
Copy link
Member

Patch for jquery.strengthify.js: nextcloud/strengthify#14

@LukasReschke
Copy link
Member

cc @MorrisJobke

LukasReschke added a commit that referenced this issue Mar 26, 2017
@LukasReschke
Use eval instead of $.script
08acb2b 
Fixes #4067

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke added a commit that referenced this issue Mar 26, 2017
@LukasReschke
Use eval instead of $.script
12a019d 
Fixes #4067

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke mentioned this issue Mar 26, 2017
Merged
@LukasReschke
Copy link
Member

And for the files_markdown app: #4068

MorrisJobke pushed a commit to nextcloud/strengthify that referenced this issue Mar 26, 2017
@LukasReschke @MorrisJobke
Use eval directly (#14)
82d63c3 
* Use eval directly

We've overwritten jQuery.globalEval() for security reasons in Nextcloud, to make this now compatible again I've changed this code to manually call eval.

Ref nextcloud/server#4067

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

* Increase version to 0.5.2

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@MorrisJobke MorrisJobke mentioned this issue Mar 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasReschke LukasReschke

Labels
bug
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging a pull request may close this issue.

Update strengthify and fix password strength nextcloud/server
2 participants
@LukasReschke @michaelletzgus