[BITV]: Modal window improvements

[JuliaKirschenheuter]

This is accessibility issue.

All necessary dialog parameters like role="dialog" aria-modal="true" aria-labelledby="modal-name-knqim" have to be on the modal dialog window, please check. Seems to be already the case

https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/

[susnux]

@JuliaKirschenheuter should the properties be on the modal mask (meaning including the next / prev buttons etc) or just on the modal content (the inner "window")?

[susnux]

(They are currently on the mask)

[JuliaKirschenheuter]

Actually i think it is right how it is implemented right now. Probably there was some misunderstanding with Michael during our call. I think all this props have to be on the mask.

@michaelnissenbaum could you please make a double check and take as example a modal window on settings/users -> "+ New user"?

[michaelnissenbaum]

Hi @JuliaKirschenheuter , I've tested it now on both Windows and Mac with NVDA and VoiceOver, and it seems to be working. I have only one note. The close button in the dialog should ideally be labeled "Close" and not "Close modal."