Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of the search providers according to the order of apps in the navigation bar #41243

Open
ostasevych opened this issue Nov 2, 2023 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: search

Comments

@ostasevych
Copy link

Please, change the order how the search results are shown according to the /ocs/v2.php/search/providers in accordance of the order of apps shown on the navigation bar. Usually Files should be at the first place.

This will help developers of third-party apps to use more actual list of search providers, see eg https://github.com/callmemagnus/nextcloud-searchpage

@ostasevych ostasevych added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Nov 2, 2023
@solracsf
Copy link
Member

solracsf commented Nov 2, 2023

What's the point here? Developpers can retrieve the providers and reorder/filter them as they need.

@ostasevych
Copy link
Author

ostasevych commented Nov 2, 2023

What's the point here? Developpers can retrieve the providers and reorder/filter them as they need.

The thing is about user: if user decides that Files should be the first app, that means, that he/she prioritises the output from this app for him/her. So, the provider Files should the first one in the list.

Developers are not willing to change the order, but mostly follow the logic of the server. This is the response from https://github.com/callmemagnus/nextcloud-searchpage

@joshtrichards
Copy link
Member

joshtrichards commented Nov 3, 2023

It looks like callmemagnus/nextcloud-searchpage#14 is the context.

Each provider (app) influences the search order via getOrder():

https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/search.html

Navigation order is managed separately:

https://docs.nextcloud.com/server/latest/developer_manual/app_development/info.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: search
Projects
None yet
Development

No branches or pull requests

3 participants