Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom location for themes #4137

Closed
jluttine opened this issue Mar 29, 2017 · 6 comments
Closed

Custom location for themes #4137

jluttine opened this issue Mar 29, 2017 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in. Nice to have

Comments

@jluttine
Copy link

Currently, data/, apps/ and assets/ directories can be given custom locations (datadirectory, apps_paths and assetdirectory). This is good because these locations are mutable, so one might want to keep them outside the actual Nextcloud installation. However, I couldn't find similar configuration for themes/ directory. It says on the docs:

The default location for themes is nextcloud/themes/.

But I couldn't find how to change this default. Perhaps, Nextcloud could support themedirectory config value (or, if necessary, an array of paths)?

@MorrisJobke
Copy link
Member

@LukasReschke @nickvergessen @icewind1991 @rullzer @karlitschek Do we want this? Generally speaking I don't like to add yet another tweak able folder location. This only leads to more complex testing scenarios and possible corner cases

@MorrisJobke MorrisJobke added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Mar 30, 2017
@jluttine
Copy link
Author

I'll try to provide some motivation here.

I need to be able to have all the files and directories that are modified by the Nextcloud process itself elsewhere. That is config/, data/, apps/, assets/ and themes/. For all others than themes/ this is already possible. (I wouldn't mind having just one setting for such a directory which would be the parent directory of those instead of having a setting for each directory individually, but that's a different story, I guess.)

Keeping the Nextcloud installation immutable has some beneftis:

  • It is possible to use the same installation for several instances by using different configuration for each instance.

  • It simplifies managing strong permission security as the actual installation needs to have only read access and the mutable directories located elsewhere have write access for the Nextcloud/HTTP process.

  • Upgrading Nextcloud is easy because one can just "switch" the Nextcloud directory old content to the new version content without needing to worry about, for instance, deleting files that no longer exist in the new version or accidentally overwriting some files modified by the Nextcloud instance.

I'm currently writing packaging/configuration for Nextcloud in NixOS which stores package installations as immutable. I want to use the nix package manager for managing the Nextcloud installation/upgrading, thus i need to be able to locate all mutable directories elsewhere.

@karlitschek
Copy link
Member

Hmm. Well the theme directory is actually not changed by Nextcloud itself. So not sure why this is a critical feature. Saying that: Making a config.php option that enabled to overwrite the theme folder shouldn't be super hard or risky. Pull requests welcome from my perspective :-)

@jluttine
Copy link
Author

Yes, the directory isn't changed by Nextcloud itself, true, I was a bit sloppy in my wording. The problem is that it is "mutable": it is modified in order to use new themes, so it's not really part of the core Nextcloud package, which I'd like to keep immutable. Just wanted to know if you supported or were against having a customizable theme location (or if it happened to be possible already). Probably relatively easy task for someone (including me) to tackle and create a pull request.

@nickvergessen nickvergessen added enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Mar 30, 2017
@nickvergessen
Copy link
Member

It is possible to use the same installation for several instances by using different configuration for each instance.

You shouldn't really do that.....

Anyway, the request sounds fine to me and I tend to agree that there shouldn't be a lot wrong with it.

@MorrisJobke MorrisJobke changed the title Feature request: Custom location for themes Custom location for themes Apr 5, 2017
@juliushaertl juliushaertl added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 2, 2017
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Oct 1, 2018
@MorrisJobke
Copy link
Member

As this sounds like a nice feature, the requests for this are quite low. Currently there are no plans to implement such a feature. Thus I will close this ticket for now. This does not mean we don't want this feature, but it is simply not on our roadmap for the near future. If somebody wants to implement this feature nevertheless we are happy to assist and help out.

If you wish to have this feature implemented by the Nextcloud GmbH there is the option for consulting work on top of your Nextcloud Enterprise subscription to get your features implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in. Nice to have
Projects
None yet
Development

No branches or pull requests

9 participants