Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to update share expiration date #43256

Closed
4 of 8 tasks
Fenn-CS opened this issue Feb 1, 2024 · 3 comments · Fixed by #43661
Closed
4 of 8 tasks

[Bug]: Unable to update share expiration date #43256

Fenn-CS opened this issue Feb 1, 2024 · 3 comments · Fixed by #43661
Assignees

Comments

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Feb 1, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Changing share expiration date does not work immediately, unless expiration date is completely unset and then set again.

Steps to reproduce

  1. Create share with expiration date
  2. Update expiration date to value allowed by configuration
  3. Save
  4. Verify

Expected behavior

Once a new date is entered and save is clicked, the new date should be applied

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@Fenn-CS Fenn-CS added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 1, 2024
@Fenn-CS Fenn-CS self-assigned this Feb 1, 2024
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Feb 1, 2024

Additionally, when creating a new share, if the set expiration date is unchecked, the expiration date is set anyways.

@susnux
Copy link
Contributor

susnux commented Feb 3, 2024

same on 28

@doits
Copy link

doits commented Feb 7, 2024

👍 28.0.2 really did break creating shares for us, definitely a regression in a minor version upgrade

@Fenn-CS Fenn-CS removed the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Feb 13, 2024
Fenn-CS added a commit that referenced this issue Feb 19, 2024
In 04e8733 a regression was introduced.
`this` means nothing inside arrow functions, hence this.share was referring to
an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit that referenced this issue Feb 20, 2024
In 04e8733 a regression was introduced.
`this` means nothing inside arrow functions, hence this.share was referring to
an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
backportbot bot pushed a commit that referenced this issue Feb 20, 2024
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
Fenn-CS added a commit that referenced this issue Feb 20, 2024
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
backportbot bot pushed a commit that referenced this issue Feb 20, 2024
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
Fenn-CS added a commit that referenced this issue Feb 20, 2024
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
solracsf pushed a commit that referenced this issue Feb 21, 2024
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit that referenced this issue Feb 21, 2024
In 04e8733 a regression was introduced.

`this` means nothing inside arrow functions, hence this.share was referring to

an undefined object and so all attempted updates for expiration dates would fail.

Resolves : #43256

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants